search

kanaka / mal

mal - Make a Lisp
Other
10k stars 2.53k forks source link

A new cpp implementation #641

Open yang-le opened 1 year ago

yang-le commented 1 year ago

Hi, I made a new cpp implementation, hope you all like it. If you have any concern, feel free to ping me.

yang-le commented 3 weeks ago

Hi @kanaka, I updated my fork to sync with the HEAD. Also renamed cc to cpp.2. My implementation used a "modern" style of C++, C++17 to be exact. I don't know why this introduced 135 commits, from my side there are only 42 commits. Do I need to make a new pull request in case you are interested in these commits?

kanaka commented 3 weeks ago

@yang-le Maybe you did a merge rather than a rebase? You should be able to rebase again to remove the commits that it pulled in that aren't related to your change.

yang-le commented 3 weeks ago

@kanaka I'm afraid that I don't have the time to improve this PR further. Please feel free to close this PR. However, I'll be happy if someone would fork my code and take that step. Thanks.