Open jcguu95 opened 5 months ago
@jcguu95 If it can be restructured to fit the code layout of other implementations (https://github.com/kanaka/mal/blob/master/docs/FAQ.md#code_split) then I would be willing to consider merging it. Otherwise, if that's too complicated or unwieldy then keeping it separate is probably best. Although I would be happy to include a link to it in the top level README if you like in the "External Implementations" section.
Hello Joel Martin! Thanks for your inspiring work! Based on your python implementation, I implemented a compiled version:
python-compile
. It passes all relevant tests (forstep2
tostepA
, regular and soft), and it is 16 times faster per the performance test suite.Would you like to merge this, or would you rather keep this maintained separately? Please let me know.
Cheers, Jin