search

kanaka / wac

WebAssembly interpreter in C
Other
472 stars 46 forks source link

Sandbox #3

Closed mbillingr closed 5 years ago

mbillingr commented 7 years ago

I have implemented restricted exports as discussed in #2.

I tried to keep changes to core wac minimal. If an optional callback is passed to load_module it is used to look up imports. If NULL is passed the symbols are resolved as usual. This implies a small API change because default arguments and function overloading is not available in C, if I am not mistaken.

These are quite a bunch of commits, some of them a bit tangential to the final result. I can squash them together if necessary.

kanaka commented 6 years ago

@mbillingr sorry, I never got back to you on this. Are you still interesting in getting this into the tree? If you're still interested, then let me know and I'll spend some time going over the PR and suggesting some changes (probably minor and including squashing some of the commits) before I merge it in.

mbillingr commented 6 years ago

@kanaka I had not even realized how much time has passed since then :) At the moment, I am no longer working with WebAssembly, so getting this PR is not particularly important for me. If you find it useful I am happy to clean it up and incorporate any suggestions.

mbillingr commented 5 years ago

Let's keep your repository tidy :)