search

kanaverse / kana

Single cell analysis in the browser
https://kanaverse.org/kana/
MIT License
142 stars 12 forks source link

Fix references to unique factor levels in UI. #242

Closed LTLA closed 1 year ago

LTLA commented 1 year ago

Fixes #241, stemming from some old uses of __unique__.

This all fundamentally stems from the fact that the logic in

https://github.com/kanaverse/kana/blame/271f1f1ff84be447c750ff373c8c7cbaf41698df/src/workers/helpers.js#L356-L381

is pretty difficult to follow when considering the opaque output of summarizeArray.

I'd suggest moving the source of summarizeArray out of bakana and into this file, to avoid future surprises from misunderstandings of the summarizeArray output.