Callback URL displayed incorrectly with Cloudron OAuth

kanboard / plugin-oauth2

Generic OAuth2 authentication plugin

MIT License

27 stars 33 forks source link

Callback URL displayed incorrectly with Cloudron OAuth #4

Closed gramakri closed 6 years ago

gramakri commented 7 years ago

I have testing this plugin with Cloudron OAuth and it works well. One issue is that the Callback URL is incorrect. It displays the port 8000. Kanboard is behind a reverse proxy on the Cloudron. The reverse proxy sets X-Forwarded-Host (test.cloudron.info), X-Forwarded-Proto (https) and X-Forwarded-Ssl (On).

gramakri commented 7 years ago

Note that only the display is incorrect. Removing the "8000" when adding it as Cloudron OAuth Client works perfectly.

fguillot commented 7 years ago

Kanboard doesn't read the X-Forwarded-Host header (PR welcome). However, you can still set the application url in settings if Kanboard is not able to guess the proper URL.

gramakri commented 7 years ago

@fguillot I can submit a PR but I couldn't figure where that value comes from :) https://github.com/kanboard/plugin-oauth2/blob/master/Template/config/integration.php#L4 wasn't clear to me (sorry, I am not a PHP developer). But any hint as to what it does might help.

ghost commented 6 years ago

This issue has been closed automatically for inactivity after more than 1 year. Unfortunately, this project doesn't have enough resources to manage all these requests. Read the FAQ.