kandanapp / kandan

Kandan is an Open Source Alternative to HipChat
GNU Affero General Public License v3.0
2.71k stars 406 forks source link

Emoji support #15

Closed jrgifford closed 11 years ago

jrgifford commented 11 years ago

So, this is kind of a proposed enhancement:

Github and Campfire support Emoji - so :100: and :green_heart: read as :100: and :green_heart:, respectively. Lots of other options, full list is here.

Is this something we want to support in Kandan?

not a 1.0 thing, this is a potentially non-backwards compatible change.

jrgifford commented 11 years ago

https://github.com/hassankhan/emojify.js looks like an easy way to implement basic support.

jrgifford commented 11 years ago

we could also pass it through a rails helper. - https://github.com/github/gemoji

kirantpatil commented 11 years ago

+1 for "gemoji"

fusion94 commented 11 years ago

I think this would be something that get's bucketed under wishlist milestone until we get 1.0/1.1 out the door.

sgrove commented 11 years ago

I'd recommend keeping as much client-side as possible, generally - we've found it's considerably nicer for separating concerns, reasoning, and ultimately porting app cleanly to different platforms when necessary.

On Fri, Jan 25, 2013 at 12:39 AM, Tony Guntharp notifications@github.comwrote:

I think this would be something that get's bucketed under wishlist milestone until we get 1.0/1.1 out the door.

— Reply to this email directly or view it on GitHubhttps://github.com/kandanapp/kandan/issues/15#issuecomment-12692288.

jrgifford commented 11 years ago

Ok. Moving it to the backend also defeats the purpose of using something like backbone.

James Gifford cell: 2162238574

jimmybrancaccio commented 11 years ago

I'll +1 for gemoji. I was just about to post an issue for it, glad I looked first! :smile:

fusion94 commented 11 years ago

@gabcen since you did emoticons do you think you can knock this out quickly?

gabceb commented 11 years ago

If somebody can create a PR adding the emoticons to the list on https://github.com/kandanapp/kandan/blob/master/app/assets/javascripts/backbone/plugins/emoticons.js.coffee#L11. I can change the regex for it later. I am kind of busy with the admin stuff. Otherwise I can knock it out once I am done with admin