search

kandanapp / kandan

Kandan is an Open Source Alternative to HipChat
GNU Affero General Public License v3.0
2.71k stars 406 forks source link

Removal of _bushido-faye has broken the app #163

Closed mjtko closed 11 years ago

mjtko commented 11 years ago

While removing the _bushido-faye fork is a good plan, we should still be specifying the dependency on faye in the Gemfile. :grin:

jrgifford commented 11 years ago

Interesting. Not sure why we need it, since we rent using web sockets on heroku...

James Gifford 2162238574 On Mar 2, 2013 6:14 AM, "Mark J. Titorenko" notifications@github.com wrote:

While removing the _bushido-faye fork is a good plan, we should still be specifying the dependency on faye in the Gemfile. [image: :grin:]

— Reply to this email directly or view it on GitHubhttps://github.com/kandanapp/kandan/issues/163 .

mjtko commented 11 years ago

We need it as it provides the pubsub framework. :smile:

While we're not using the websocket part of it (which, although it isn't supported on Heroku [yet!], could be supported on privately deployed servers) we are using EventSource for incoming messages to the GUI app.

mjtko commented 11 years ago

FWIW, it's not an obvious dependency at the moment as it's only referred to in config.ru and in lib/broadcasters, neither of which are covered by tests AFAICS.