search

kandanapp / kandan

Kandan is an Open Source Alternative to HipChat
GNU Affero General Public License v3.0
2.72k stars 407 forks source link

A more SSL friendly Kandan. #323

Closed gaelian closed 10 years ago

gaelian commented 10 years ago

The MusicPlayer, VimeoEmbed and YouTubeEmbed plugins are now protocol agnostic and will work with SSL/non-SSL Kandan install.

The standard Gravatar address in kandan_settings.yml now defaults to the SSL Gravatar address.

Closes #322.

gaelian commented 10 years ago

Ordinarily I would include some tests with my PRs, but as I note from your Travis output and my own investigations that your specs seem to be in a state of flux at the moment, I can't see any coverage of your Backbone.js classes in any case, and my changes are quite innocuous, I will forgo adding specs at this time. I've manually tested these changes on my own Kandan install using both SSL and non-SSL and I can't find any issues. If any issues are found, I'm more than happy to update my PR. Should there be a time in the future when your test suite is back to full working order, I'd also be happy to look into adding some coverage for my changes at that time.

By the way, you might also want to update the README for your kandan-dev-vm project, as I found that your VM no longer works with VirtualBox 4.2.12.