search

kandanapp / kandan

Kandan is an Open Source Alternative to HipChat
GNU Affero General Public License v3.0
2.72k stars 408 forks source link

Support new notification #371

Closed publichtml closed 9 years ago

publichtml commented 10 years ago

Replace webkitNotification APIs with Notification.

The old webkitNotification API is deprecated and abolished in Chrome 35. So I alter codes using webkitNotification to use new Notification APIs. (I also update Modernizr 2.6.2 -> 2.8.2 because 2.6.2 does not support Notification )

It's will support Chrome 22+ and Firefox 22+.

jrgifford commented 9 years ago

:+1:, nice work. Any objections from others on the team?

scouttyg commented 9 years ago

While this pull request came before #381, I pulled in the other one because the user had signed the Contributor License agreement. Apologies for this, and hope the notification issue is now fixed.

publichtml commented 9 years ago

No problem. I'll signed the Contributor License in the next time and I'm sorry that I did not do so in this PR. thx!