search

kandanapp / kandan

Kandan is an Open Source Alternative to HipChat
GNU Affero General Public License v3.0
2.72k stars 408 forks source link

Shouldn't matter if a user is messaging from a separate tab or device... #372

Closed Arduinology closed 9 years ago

Arduinology commented 10 years ago

under the same user name, chat history should always broadcast.

scouttyg commented 9 years ago

Could you explain this a little more? Currently if you post a message, it should not make a sound if you post something - a sound should be reserved for messages you know you didn't post (See: GChat). A noise will be made if you open up the chat in two tabs or windows, however.

Also, don't forget to sign the CLA!

Arduinology commented 9 years ago

@scouttyg picture this, you have kandan on your table and kandan on your computer. If you post a message in chat from one device you will be unable to view that message on the other device. This is an issue. The chat log should be broadcast regardless of this situation.

scouttyg commented 9 years ago

I think this should be fixed by #400 now -- there was some bugs with the code above, but they should be solved now. In the mean time, I'll close this and let me know if the latest changes help.