search

kandanapp / kandan

Kandan is an Open Source Alternative to HipChat
GNU Affero General Public License v3.0
2.72k stars 408 forks source link

Fixed auto-scroll to latest message when new activity appears. #387

Closed JangoSteve closed 9 years ago

JangoSteve commented 9 years ago

Finally figured out why the message area wasn't scrolling down when a new message is received (making the user have to manually scroll down in message pane to see any new messages). It was due to a typo in the jQuery selector to get the current scroll position.

This method is called by the @pastAutoScrollThreshold function, which is called by @addActivity function to see if it should auto-scroll down to the last message after inserting a new message. This would cause currentPosition to be equal to null, causing scrollPosition to be NaN, which would result in the function returning false.

scouttyg commented 9 years ago

Nice, I'm sure this will help a good deal of people.