search

kandanapp / kandan

Kandan is an Open Source Alternative to HipChat
GNU Affero General Public License v3.0
2.72k stars 408 forks source link

Fix travis failure caused by bundle install #394

Closed uk-ar closed 9 years ago

uk-ar commented 9 years ago

Only 1.9.2 and 1.9.3 are supported in debugger gem(https://github.com/cldwalker/debugger#known-issues). In 2.0 ruby, using byebug instead.

scouttyg commented 9 years ago

This makes a lot of sense, but I'd hate to screw up older users with a different Gemfile.lock. Let me know what your thoughts are on this.

uk-ar commented 9 years ago

I did not think about older Ruby version users. Now, I think that it is better way to remove both debugger and byebug, because there is no solution which satisfy 1.9 Ruby user and 2.0 Ruby user.

bodrovis commented 9 years ago

+1, I've had to remove debugger completely to boot this with Ruby 2.

scouttyg commented 9 years ago

@uk-ar I think this solution is probably good enough for now -- let's put this in and revert it if it ends up being too much trouble.