kandanapp / kandan

Kandan is an Open Source Alternative to HipChat

GNU Affero General Public License v3.0

2.72k stars 408 forks source link

Support hubot api #438

Closed miurahr closed 8 years ago

miurahr commented 9 years ago

393 is incomplete support for hubot master branch. It produce 404 error for /me? /channels? api access.

because API with auth_token is considered as unauthorized access in routes.rb.

Here is additional fix to #393 PR. This PR is tested against hubot master.

miurahr commented 9 years ago

In previous PR , I just put API related resources out of constraints (authenticated :user). Additional https://github.com/miurahr/kandan/commit/e42d51a71c0aad0ed45aa2de2112236efac51f75 aim to explicitly authenticate as user or token.

Because it is not working for channels:activities nested resource, put these out of authorized_or_have_token constraints. welcome suggestions!

coveralls commented 9 years ago

Coverage decreased (-0.64%) to 69.21% when pulling e42d51a71c0aad0ed45aa2de2112236efac51f75 on miurahr:support_hubot_api into 4a7d91216133d2260ce2dc0660e41f0003d2ca98 on kandanapp:master.

miurahr commented 9 years ago

Due to a failure of Travis CI test, I've reverted last modifications. It will be tried again in a separate PR.

miurahr commented 8 years ago

Drop here and I'd like to submit cleaned PR agian.