search

kandashi / Next-Up

Auto focus on new combatant
MIT License
12 stars 9 forks source link

Token Marker Issues in OSE #133

Open justinthejaguar opened 2 years ago

justinthejaguar commented 2 years ago

Describe the bug Sometimes the turn marker will appear in multiple positions or not appear at all on actors. Marker will not disappear upon combat completion. *edit: After further testing this issue will cause the actor count in combat to continuously toggle in group initiative when rolled at the top of each round in some instances. This will freeze combat the combat tracker.

To Reproduce Steps to reproduce the behavior:

  1. Run a world using the Old-School Essentials System
  2. Create multiple actors and initiate combat
  3. Flag combatants
  4. Run through several turns. (It was quite a few before the toggling issue. 32-167 rounds in some instances or the first round in others)
  5. Check console.
  6. End Combat

Expected behavior The marker should indicate the token corresponding to turn order.

Screenshots Screen Shot 2022-01-15 at 4 44 08 PM Screen Shot 2022-01-15 at 4 44 37 PM image

Environment:

Additional context There is currently a bug being identified in OSE for multiple initiative rolls rather than just the group initiative. This will be evident in mass combat of 14 actors or extremely long combat. This can get intensive on the CPU and is being worked on as a top priority. *** The bug has since been fixed, but the issue still occurs of toggling the combatants continuously when Next Up is enabled.

justinthejaguar commented 2 years ago

image

The initiative issue in OSE has been gone, and I decided to take another stab at this. It seems like the turn marker function is causing an extra reroll and leaving a token marker on the last character in the character initiative list. Turn marker appears to end at the end of combat now.