search

kandashi / Next-Up

Auto focus on new combatant
MIT License
12 stars 9 forks source link

Starting marker 404 error on Forge hosting #88

Closed benjosity closed 3 years ago

benjosity commented 3 years ago

Seems as though the string formatting for the start marker isn't being formatted with Forge hosting taken into account causing a 404 error. Turn marker is working fine with the same URL format specified.

Turn Marker - https://assets.forge-vtt.com/bazaar/modules/jb2a_patreon-2d960ceba80cc778/assets/Library/Generic/Magic_Signs/Conjuration_01_Yellow_Circle_800x800.webm

Start-Turn Marker - https://assets.forge-vtt.com/bazaar/modules/Next-Up/assets/Markers/start.png

Screenshot 2021-06-04 at 16 36 33
kakaroto commented 3 years ago

It looks like you entered /assets.forge-vtt.com/bazaar/modules/Next-Up/assets/Markers/start.png as the url for the marker, instead of https://assets.forge-vtt.com/bazaar/modules/Next-Up/assets/Markers/start.png. I was told it works fine when using the url with the https:// protocol included. Can you confirm ?

kandashi commented 3 years ago

ahh, this is likely on the 0.7.6 branch where had to do some finicky stix to make a file picker work. The 0.8.6 branch should work fine here

Th3Rom3 commented 3 years ago

I can replicate the problem on a local node.js installation. Turn marker icon seems fine but the path to the start-turn marker seems to be constructed in a weird way. It always seems to cut of the first seven characters of the relative path. If I manually change the relative path from

modules/Next-Up/Markers/BlackCross.png to 1234567modules/Next-Up/Markers/BlackCross.png

It works and the remaining path that is referenced in engine is correct and the icon is applied. I sadly cannot provide more sophisticated input at the moment since I would have to look more into javascript syntax. If I can provide additional layman's info let me know.

grafik

Th3Rom3 commented 3 years ago

I would speculate that this might be the same problem with the forge hosting since the URL in benjosity/kakaroto's post is also missing the first seven characters.

kandashi commented 3 years ago

Yes, this is a result of how the 0.7.6 version works I'm afraid

Th3Rom3 commented 3 years ago

I should have clarified, I am running Foundry 0.8.6. on node.js 14.17.

My bad.

The workaround is fine enough for me. Just wanted to post my findings.

kandashi commented 3 years ago

If you are on 0.8.6 make sure you are using the new version 0.1.01 as this works fine on the forge system

kandashi commented 3 years ago

I now see what the issue is, will fix now