kandashi / condition-automation

Automated Conditions Foundry VTT
10 stars 5 forks source link

[Enhancement] Provide API to opt out of (or in to?) hover+shadow effect when changing elevation? #43

Open Doresain opened 3 years ago

Doresain commented 3 years ago

Hey Kandashi, love your work. I really dig the effect you have here for flying/levitating tokens, but I had to disable it the other day and I'm trying to think through how I could keep it and still solve my use case (which I don't think is unique to me?). Let me explain the case and tell you what I'm thinking and we'll see if it makes sense.

I'm using the Wall Height module to set the elevation of various walls in a scene. In some cases, namely city walls, it is possible for players to get on top of these walls and look over them. I have macros set up to automatically set the token's elevation to the elevation of the wall when the player climbs on top of it. All of this is based on Baileywiki's excellent Modular Town module.

All of this works great, except that this Condition Automation module applies the shadow + rotate effects to any >0 elevation, which looks amazing when a token is flying but looks sort of ??? when they are just standing on a tall wall, hah. Example: https://i.imgur.com/zqgOlVO.mp4

So here's what I'm thinking: I assume you're setting or removing these effects at the time the token is updated with the new elevation? I don't know the foundry APIs well enough to know if this is possible, but if I could add an additional call to my macro to ignore the next elevation update? Or a flag on the token.update that clues this module in to ignore the elevation until it is removed?

Or, even better maybe, a module setting that causes this module to ignore elevation updates unless a specific API is called, which could then be added to macros for fly/levitate/etc (opting in instead of opting out).

Anyway, you see where I'm going here.

kandashi commented 3 years ago

This is a good idea, and the whole module needs a re-work really