kandashi / midi-srd

MIT License
7 stars 29 forks source link

Compatibility with V10 #25

Open davelamorte opened 2 years ago

davelamorte commented 2 years ago

Hello, the module cannot be opened or installed with V10, please add the compatibility.

Thanks!

kandashi commented 2 years ago

None of my modules are yet updated for v10. Do not expect quick updates as I have very little time on my hands right now

davelamorte commented 2 years ago

Thank you for letting us know! Keep up the good work.

AlexSledge commented 2 years ago

The only issue I had installing it on v10 is:

setup.js:141 [midi-srd] Metadata validation failed for module "midi-srd": The file "scripts/midiSRD-styles.css" included by module midi-srd does not exist

fix: rename file midiSRD-style.css -> midiSRD-styles.css or fix references

Seems fine with v10 otherwise

CaosFR commented 2 years ago

@AlexSledge Thanks for your reply. @kandashi good luck with the update.

kiloforce commented 2 years ago

The only issue I had installing it on v10 is:

setup.js:141 [midi-srd] Metadata validation failed for module "midi-srd": The file "scripts/midiSRD-styles.css" included by module midi-srd does not exist

fix: rename file midiSRD-style.css -> midiSRD-styles.css or fix references

Seems fine with v10 otherwise

Your suggested fix worked for me, thanks!

geoidesic commented 2 years ago

@AlexSledge Can you create a Pull Request for this?

geoidesic commented 2 years ago

Actually I think there is already one: https://github.com/kandashi/midi-srd/pull/29 @kandashi can you please merge it?

AlexSledge commented 2 years ago

It's actually 28, but yeah there is one. I was going to check if it's more appropriate to rename the file, or change the reference to the file, but either avenue works.

geoidesic commented 2 years ago

Cum on @kandashi ! Click the merge button! It takes 2 seconds from your day.

eyeboxone commented 2 years ago

Can't even enable the module. "Cannot be enabled due to issues in required dependencies" Not sure which dependencies it requires.

AlexSledge commented 2 years ago

It requires dae, midi-qol, advanced-macros and times-up

CaosFR commented 2 years ago

@kandashi Hi, any news, tests, or a timeline for the update ?

eyeboxone commented 1 year ago

When I open the MIDI-SRM the compendium items appears broken. Is this just all the broken references due code changes for v10?

image

thatlonelybugbear commented 1 year ago

.

Will repackage properly the v10 forked MidiSRD and post it back

CaosFR commented 1 year ago

@thatlonelybugbear Thanks for your work, I have tested your fork. Great job.

thatlonelybugbear commented 1 year ago

For anyone interested, you can grab an installable version of Midi SRD for v10 Foundry using the link to manually install.

https://github.com/thatlonelybugbear/midi-srd/blob/master/module.json

I will be fixing issues as time passes, so any reports of what is working or not, would be really helpful.

EndlessEpiphany commented 1 year ago

Screenshot 2022-11-06 at 6 50 32 PM I'm on a mac (not sure if it makes a difference) and these are the errors I get when attempting an install.

thatlonelybugbear commented 1 year ago

edit: I did link the same as above by mistake 🤦

Quidam2k commented 1 year ago

That didn't work for me, but this did https://raw.githubusercontent.com/thatlonelybugbear/midi-srd/master/module.json

vithort commented 1 year ago

It requires dae, midi-qol, advanced-macros and times-up

require more dependencies, you need install all this modules to can enable the Midi SRD...

"requires": [
    {
        "id": "dae",
        "type": "module"
    },
    {
        "id": "midi-qol",
        "type": "module"
    },
    {
        "id": "advanced-macros",
        "type": "module"
    },
    {
        "id": "foundryvtt-simple-calendar",
        "type": "module"
    },
    {
        "id": "times-up",
        "type": "module"
    },
    {
        "id": "warpgate",
        "type": "module"
    }
]

i try, and warpgate is not necessary :D

zabu61 commented 1 year ago

That didn't work for me, but this did https://raw.githubusercontent.com/thatlonelybugbear/midi-srd/master/module.json

Confirmed, worked for me as well, and thank you very much!