Open davelamorte opened 2 years ago
None of my modules are yet updated for v10. Do not expect quick updates as I have very little time on my hands right now
Thank you for letting us know! Keep up the good work.
The only issue I had installing it on v10 is:
setup.js:141 [midi-srd] Metadata validation failed for module "midi-srd": The file "scripts/midiSRD-styles.css" included by module midi-srd does not exist
fix: rename file midiSRD-style.css -> midiSRD-styles.css or fix references
Seems fine with v10 otherwise
@AlexSledge Thanks for your reply. @kandashi good luck with the update.
The only issue I had installing it on v10 is:
setup.js:141 [midi-srd] Metadata validation failed for module "midi-srd": The file "scripts/midiSRD-styles.css" included by module midi-srd does not exist
fix: rename file midiSRD-style.css -> midiSRD-styles.css or fix references
Seems fine with v10 otherwise
Your suggested fix worked for me, thanks!
@AlexSledge Can you create a Pull Request for this?
Actually I think there is already one: https://github.com/kandashi/midi-srd/pull/29 @kandashi can you please merge it?
It's actually 28, but yeah there is one. I was going to check if it's more appropriate to rename the file, or change the reference to the file, but either avenue works.
Cum on @kandashi ! Click the merge button! It takes 2 seconds from your day.
Can't even enable the module. "Cannot be enabled due to issues in required dependencies" Not sure which dependencies it requires.
It requires dae, midi-qol, advanced-macros and times-up
@kandashi Hi, any news, tests, or a timeline for the update ?
When I open the MIDI-SRM the compendium items appears broken. Is this just all the broken references due code changes for v10?
.
Will repackage properly the v10 forked MidiSRD and post it back
@thatlonelybugbear Thanks for your work, I have tested your fork. Great job.
For anyone interested, you can grab an installable version of Midi SRD for v10 Foundry using the link to manually install.
https://github.com/thatlonelybugbear/midi-srd/blob/master/module.json
I will be fixing issues as time passes, so any reports of what is working or not, would be really helpful.
I'm on a mac (not sure if it makes a difference) and these are the errors I get when attempting an install.
edit: I did link the same as above by mistake 🤦
That didn't work for me, but this did https://raw.githubusercontent.com/thatlonelybugbear/midi-srd/master/module.json
It requires dae, midi-qol, advanced-macros and times-up
require more dependencies, you need install all this modules to can enable the Midi SRD...
"requires": [
{
"id": "dae",
"type": "module"
},
{
"id": "midi-qol",
"type": "module"
},
{
"id": "advanced-macros",
"type": "module"
},
{
"id": "foundryvtt-simple-calendar",
"type": "module"
},
{
"id": "times-up",
"type": "module"
},
{
"id": "warpgate",
"type": "module"
}
]
i try, and warpgate is not necessary :D
That didn't work for me, but this did https://raw.githubusercontent.com/thatlonelybugbear/midi-srd/master/module.json
Confirmed, worked for me as well, and thank you very much!
Hello, the module cannot be opened or installed with V10, please add the compatibility.
Thanks!