kandashi / midi-srd

MIT License
7 stars 29 forks source link

Hideous Laughter problems. #5

Open Orionox opened 2 years ago

Orionox commented 2 years ago

Alright, so there appear to be issue with two of the hideous Laughter options in the Midi SRD when cast on PC's, not sure if the effects affect NPC's equally.

1) Hideous Laughter: successfully applies a hideous Laughter effect, a prone effect, and an incapacitated effect. It also automatically rolls at the end of each round. Unfortunately, the spell DC is stuck at -1, so the roller always succeeds, and even though the roller is succeeding, the conditions are never auto removed. Not game-breaking, but I assume each of these are made with autoremoval after a successful save in mind.

2) Hideous Laughter (macro): The initial application is smooth and all chat cards and rolls act as expected and it successfully applies a Hideous Laughter effect and works pretty well. The problems with this spell are mostly cosmetic, but it does clutter up the chat with erroneous rolls. When a turn is passed, a "Damage Over Time" chat card is produced showing the DC at -1 and a useless roll is automatically generated and applied to the chat card but does not clear the status effect on a success. Simultaneously, you are prompted to make another roll. If you exit out of the prompt, This error is thrown....

 Macros.js:212 TypeError: Cannot read property 'total' of null
    at RollHideousSave (eval at callScriptMacroFunction (Macros.js:169), <anonymous>:40:85)
    at async Macro.eval (eval at callScriptMacroFunction (Macros.js:169), <anonymous>:61:5)
    at async Macro.executeMacro (Macros.js:209)
    at async Object.daeMacro (dae.js:1186)
 #

If you follow through with the roll prompt though another normal chat card is produced showing the correct DC and if you succeed on this second roll, the condition and effect is clear as you'd expect. Unless you reload the application, which causes the condition to show back up. The only way I've found to prevent the condition/effect from showing back up through a reload is if you manually remove the effect. Overall, works well, except it seems to be generating that "damage over Time" card that appears to do nothing detailed above. Capture Useless chat card being generated

3) Hideous Laughter macro: appears to work completely normally except it has the same issue where conditions will show back up on the token after a reload. This isn't really an issue unless you apply and then save a few times, at which point a reload will have hideos laughter effect/condition for each one you removed stacked on the character Capture Applied and then saved hideous laughter 3 times, then reloaded

Also, and maybe this is expected, but none of the spells remove concentration when they are saved against