Remove remaining CUB data

kandashi / midi-srd

MIT License

7 stars 29 forks source link

Remove remaining CUB data #7

Closed MrPrimate closed 2 years ago

MrPrimate commented 2 years ago

CUB condition swaps:

Animal Friendship
Hypnotic Pattern
Sunbeam
Grease
Web
Hold Person
Hold Monster

Macro rewritten:

Divine Word
Hideous Laughter

Removed duplicate Hideous Laughter. Removed excessive/dead flag data to reduce item sizes

thatlonelybugbear commented 2 years ago

~~FYI, Just grabbed the forked spells.db and saw that there is still a duplicate Hideous Laughter in there @MrPrimate~~

MrPrimate commented 2 years ago

@thatlonelybugbear one of these is a macro one, one is without macro, I removed the duplicate macro entry.

thatlonelybugbear commented 2 years ago

Ah OK sorry. Just scanned through and saw that there was a cub.addCondition for Prone in the (now I know) Macro version of the Hideous Laughter and thought it was just forgotten in there!

MrPrimate commented 2 years ago

~~Ah! I think it can probably be removed TBH - with AboutTime and the Overtime effect I think the macro is now redundant.~~ So you probably want the maro to do the save when damaged - I'll take a look.

thatlonelybugbear commented 2 years ago

I dont use it tbh (the macro one), just scanned through the changes, and it caught my eye cause I read about the duplicate Hideous Laughter entries in your changelogs and thought whoops there is still another Hideous Laughter entry :P

Didn't even register that the 2 might be serving different purposes !