search

kandersonko / lca-tool

lca-tool
0 stars 0 forks source link

Commits Messages #24

Open georgemakrakis opened 1 year ago

georgemakrakis commented 1 year ago

It would be better to include proper messages into each commit that is being done. Messages like: Update <x,y file> and Made changes to <x,y file> do not give a good indicator on what happened to each commit, and it makes it harder to check what the particular change was.

KurtAnVedros commented 1 year ago

I will incorporate this naming covention for future updates.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: George Makrakis @.> Sent: Saturday, May 13, 2023 6:41:04 PM To: kandersonko/lca-tool @.> Cc: Vedros, Kurt @.) @.>; Assign @.***> Subject: Re: [kandersonko/lca-tool] Commits Messages (Issue #24)

Assigned #24https://urldefense.com/v3/__https://github.com/kandersonko/lca-tool/issues/24__;!!JYXjzlvb!h1ETBAcl6PIhcFJGTz9XNVfafa1WF-77r62aIrVFWeWx4QqyzbQ5AK64v1RYhpW1FkItvcxskdTC_LTEY6P-QArYO0W-jI2Ab51f$ to @KurtAnVedroshttps://urldefense.com/v3/__https://github.com/KurtAnVedros__;!!JYXjzlvb!h1ETBAcl6PIhcFJGTz9XNVfafa1WF-77r62aIrVFWeWx4QqyzbQ5AK64v1RYhpW1FkItvcxskdTC_LTEY6P-QArYO0W-jFtEhFph$.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/kandersonko/lca-tool/issues/24*event-9239381717__;Iw!!JYXjzlvb!h1ETBAcl6PIhcFJGTz9XNVfafa1WF-77r62aIrVFWeWx4QqyzbQ5AK64v1RYhpW1FkItvcxskdTC_LTEY6P-QArYO0W-jOp_yBjX$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AV3B5UH6PLU4TCC3GLWT7OTXGAS2BANCNFSM6AAAAAAYAZW6CE__;!!JYXjzlvb!h1ETBAcl6PIhcFJGTz9XNVfafa1WF-77r62aIrVFWeWx4QqyzbQ5AK64v1RYhpW1FkItvcxskdTC_LTEY6P-QArYO0W-jOke1PHT$. You are receiving this because you were assigned.Message ID: @.***>

kandersonko commented 1 year ago

I think we should also include the details about the commits in the description of the commit when the file name is long. Git recommends a commit message length of max 72 characters. For the extra details about the commit, we should probably put those in the description of the commit (third line of the commit message).

georgemakrakis commented 1 year ago

Sure that will work. I believe that will help with tracking potential issues in the future.