search

kando-menu / kando

🥧 The Cross-Platform Pie Menu.
https://ko-fi.com/post/Kando-1-0-0-released-G2G5Z1DOS
Other
1.19k stars 26 forks source link

Ability to Modify text boxes/text size and font and icon size. #364

Closed hamishC0 closed 3 months ago

hamishC0 commented 3 months ago

SCR-20240325-sldo

Often the names and icons given will overlap the edges of the nodes giving an unpolished look that I'd like to be able to modify, or for Kando to just automatically leave a buffer margin between the edge of the node and the contents.

(See the title of the top node and the icon of the bottom left node)

Schneegans commented 3 months ago

Hi there! Yeah, this is a difficult issue. Properly wrapping arbitrary text inside a circle is a surprisingly difficult problem! Right now, I am wrapping the text in a square-shaped container which is 20% smaller than the circle. However, as you have seen, this still allows the corners of the icon to touch the border of the circle.

Yet if I add more padding, the icon will look to small in most cases, and the text in the center will appear to have excessive margin.

I would rather not add a manual scale option. Kando should be smart enough to figure this out on its own :smile:. Maybe I'll add some circular cropping to the icons and implement some pseudo-circle-wrapping for the center text: If the text fits on one line, I allow the full circle width, if it requires more lines I'll reduce the allowed width to make it stay inside the circle...

hamishC0 commented 3 months ago

Ahhh okay I understand. I unfortunately don't have much (or any) experience in UI design so I can only wish you luck rather than offer useful help...

Schneegans commented 3 months ago

As I have said above, I have now implemented some circle cropping for the icons and a little more intelligent wrapping for the center text. It's not perfect, but it should be better already!

D3vil0p3r commented 2 months ago

Hello @Schneegans I think that adding manual scaling could be good for accessibility, mostly for people with eyes diseases.

Schneegans commented 2 months ago

Do you think that scaling the icons (not the menu items, only the icons drawn onto them) would improve accessibility? I mean, they are currently drawn as large as possible. Any scaling option can only shrink them.

That being said, scaling the entire menu will definitely be possible in the future. But this is not what this issue is about :wink: