kando-menu / kando

🥧 The Cross-Platform Pie Menu.
https://ko-fi.com/post/Kando-1-0-0-released-G2G5Z1DOS
Other
1.18k stars 25 forks source link

Segmentation fault on Hyprland 0.40.0 #417

Closed KAGEYAM4 closed 1 month ago

KAGEYAM4 commented 1 month ago
[ArchLinux ~]$ kando 
Running on Linux (Hyprland on wayland).
Loading settings from /home/phoenix/.config/Kando/config.json
Loading settings from /home/phoenix/.config/Kando/menus.json

The Hyprland backend is still a bit experimental!
You have to perform some manual steps to make Kando work properly.
See https://github.com/kando-menu/kando/pull/245
for more information.

Successfully loaded Kando's renderer process.
Kando 0.8.0 is ready.
Currently focused: firefox (Mozilla Firefox)
[74905:0510/155608.922243:ERROR:wayland_event_watcher.cc(43)] libwayland: error marshalling arguments for create_virtual_keyboard (signature on): null value passed for arg 0

[74905:0510/155608.922577:ERROR:wayland_event_watcher.cc(43)] libwayland: Error marshalling request for zwp_virtual_keyboard_manager_v1.create_virtual_keyboard: Invalid argument

Segmentation fault (core dumped)
Schneegans commented 1 month ago

Thanks for the report! I'll look into it. However, I have currently no Hyprland up and running, so it may take some time.

KAGEYAM4 commented 1 month ago

https://github.com/hyprwm/Hyprland/releases/tag/v0.40.0 mentions ->

virtual-keyboard: destroy on vdestroy event
virtual-keyboard: move to new impl
virtual-pointer: move to new impl
Schneegans commented 1 month ago

I was able to reproduce this issue and found a fix. The order in which the global Wayland objects get registered seems to be different now. The code should now be independent from the order.

However, on my system there seems to be another issue on 0.40.0: When Kando tries to warp the mouse pointer (which happens when you open Kando close to a screen's edge), the session crashes completely. I have no idea why this happens. In fact, this could be Hyprland bug! I look through Kando's code and didn't find anything suspicious. The mouse-move event is dispatched and then Hyprland crashes.

Is it possible for you to run the latest version of Kando from git and see if this happens to you as well?

KAGEYAM4 commented 1 month ago

I was able to reproduce this issue and found a fix. The order in which the global Wayland objects get registered seems to be different now. The code should now be independent from the order.

Thank you

However, on my system there seems to be another issue on 0.40.0: When Kando tries to warp the mouse pointer (which happens when you open Kando close to a screen's edge), the session crashes completely. I have no idea why this happens. In fact, this could be Hyprland bug! I look through Kando's code and didn't find anything suspicious. The mouse-move event is dispatched and then Hyprland crashes.

i will try to complile from git and test it.

KAGEYAM4 commented 1 month ago

@Schneegans The segmentation fault bug is fixed.

However, on my system there seems to be another issue on 0.40.0: When Kando tries to warp the mouse pointer (which happens when you open Kando close to a screen's edge), the session crashes completely. I have no idea why this happens

I am not able to replicate this, i will share screen recording, let me know if i am doing it right or not.

KAGEYAM4 commented 1 month ago

https://github.com/kando-menu/kando/assets/75798544/490930b7-9e39-4666-b403-15ddaafa02b5

KAGEYAM4 commented 1 month ago

Would it be possible for you to make a release?

Schneegans commented 1 month ago

Yeah, this seems to work perfectly fine on your end. Well, let's see if somebody else reports the problem. Maybe my super-nooby-hyprland installation is somehow screwd up :sweat_smile:

And yes, I can push a 0.8.1!

KAGEYAM4 commented 1 month ago

Yeah, this seems to work perfectly fine on your end. Well, let's see if somebody else reports the problem. Maybe my super-nooby-hyprland installation is somehow screwd up 😅

i though it maybe window rule, but seeing at my window rules, even i am not sure.

# Kando
windowrule = noblur, Kando
windowrule = noborder, Kando
windowrule = noanim, Kando

Which distro are you using for hyprland?

Schneegans commented 1 month ago

I just pushed the release!

I am using EndeavourOS. It seemed to be a quite beginner-friendly version or Arch. But I have basically zero experience with Arch, so I may have misconfigured something. Especially NVidia-related stuff was a bit of a hassle...

KAGEYAM4 commented 1 month ago

I just pushed the release!

Thank you.

I am using EndeavourOS. It seemed to be a quite beginner-friendly version or Arch. But I have basically zero experience with Arch, so I may have misconfigured something. Especially NVidia-related stuff was a bit of a hassle...

Yuup nvidia, i wasted so much time over it, in the end i just disabled nvidia completely. Now i run just integrated graphics.