kando-menu / kando

🥧 The Cross-Platform Pie Menu.
https://ko-fi.com/post/Kando-1-0-0-released-G2G5Z1DOS
Other
1.18k stars 25 forks source link

Incorrect notification "failed to execute command" #450

Closed Tal-Gordon closed 3 weeks ago

Tal-Gordon commented 3 weeks ago

Short Summary

Tried to execute two commands at the same time. Kando executed both correctly, but still outputted an error notification

Steps to Reproduce the Issue

  1. Open the editor by using the tray icon
  2. Add new "Launch Application" menu item
  3. Write in two commands (i.e. explorer "https://website1.com" & explorer "https://website2.com")
  4. Execute command via Kando

Kando Version

v1.0.0

Installation Method

Via an installer downloaded from a release on GitHub

Desktop Environment

Windows

Environment Version

Windows 11

Additional Information

It seems like the problem is related to the explorer "https://website1.com"command, since just opening two new cmd windows (via start cmd.exe) worked perfectly. However, once I tried to open a cmd window and then open a new website, the error did not appear until I closed the new cmd window.

Schneegans commented 3 weeks ago

Hi there! I think this is related to a weird behaviour (bug?) of Windows: The explorer always returns a non-zero exit code and therefore Kando hast to assume that the command failed.

Could you maybe open the URL via start "https://website1.com"?

Tal-Gordon commented 3 weeks ago

Hi there! I think this is related to a weird behaviour (bug?) of Windows: The explorer always returns a non-zero exit code and therefore Kando hast to assume that the command failed.

Could you maybe open the URL via start "https://website1.com"?

Does not work. This syntax opens a new cmd window, instead of the website. It does seem like the issue is the explorer, though, I stumbled upon it trying to open several websites at once. Is it possible?

Schneegans commented 3 weeks ago

Sorry, my mistake, it's without quotes. Windows is weird sometimes...

start https://www.google.com & start https://www.github.com
Tal-Gordon commented 3 weeks ago

Sorry, my mistake, it's without quotes. Windows is weird sometimes...

start https://www.google.com & start https://www.github.com

Yep, that does it! Thank you a lot. The failed notification can still be seen when closing opened cmd windows, but I get that it's not your fault. Cheers!😊