search

kando-menu / kando

🥧 The Cross-Platform Pie Menu.
https://ko-fi.com/post/Kando-1-0-0-released-G2G5Z1DOS
Other
1.17k stars 25 forks source link

Added tooltip to icons #500

Closed pushkardev123 closed 4 days ago

pushkardev123 commented 5 days ago

the tooltip should work fine now.

pushkardev123 commented 4 days ago

and this code is running into an error with exit code 1 for macOS, i cant get why is that, i havent changed anything related to it , it should work fine then

Schneegans commented 4 days ago

Do you refer to the failed CI job? This is just a GitHub issue. You can ignore it. I just re-run the job and i guess that it'll succeed now.

pushkardev123 commented 4 days ago

Okay i have added a few changes too, ill commit as soon as i reach home. Im at class rn.

Schneegans commented 4 days ago

Thanks again. The tooltip-code looks better now. But why did you add all kinds of dependencies? Please revert the changes you did to package.json and package_lock.json :smile:

pushkardev123 commented 4 days ago

Oh i was trying to run some tests, my bad. Right on it

pushkardev123 commented 4 days ago

reverted all the changes to package.json everything should work fine now.

Schneegans commented 4 days ago

Thanks again! It's now merged to main!

pushkardev123 commented 4 days ago

Thanks again! It's now merged to main!

Thanks to you too sir! It was really fun and I learned many things, hope I get to work more in future! Thank you for all the guiding and insights.

denis-roy commented 4 days ago

Thanks @Schneegans and good job @pushkardev123 ! 🥳