search

kando-menu / kando

🥧 The Cross-Platform Pie Menu.
https://kando.menu
Other
3.12k stars 89 forks source link

Auto Dark Mode Themes #561

Closed ognistik closed 3 months ago

ognistik commented 3 months ago

Description

I'm not sure about how this works on other systems, but in Mac it could be awesome to be able to choose a theme for dark-mode and one for normal-mode. So that when the user switches mode, the theme also changes automatically with it. Just something to consider for the new Themes Feature. Thank you!!

Affected Desktop Environments

macOS

Additional Information

No response

Schneegans commented 3 months ago

Good idea! I think we could just add an optional menuThemeDark settings key and if it is given, this is used if dark mode is enabled.

Ka1zza commented 3 months ago

Haven't tested this yet, but looks like it's easy enough to determine light/dark mode on windows.

https://stackoverflow.com/a/55670413

Not sure about Mac.

Schneegans commented 3 months ago

I think that this is even easier as Electron comes with an API for that: https://www.electronjs.org/docs/latest/api/native-theme#nativethemeshouldusedarkcolors-readonly

Schneegans commented 3 months ago

This works in the latest main branch.