feat: Added props for headerBackgroundColor and borderBottomColor - Githubissues

kanelloc / react-native-animated-header-scroll-view

React native animated header ScrollView & FlatList. Animates an image or a custom component into a navbar header.

https://www.npmjs.com/package/@kanelloc/react-native-animated-header-scroll-view

MIT License

253 stars 21 forks source link

feat: Added props for headerBackgroundColor and borderBottomColor #59

Closed newyorksoul closed 1 year ago

newyorksoul commented 1 year ago

Description

Added props for headerBackgroundColor and borderBottomColor with default values based on the Appearance setting.

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

rayhk6 commented 1 year ago

This PR is great. Any update? Thanks

butri71 commented 1 year ago

@kanelloc - all looking good. can we please have it updated it asap. Cheers

kanelloc commented 1 year ago

Closed as this overlaps with this PR: https://github.com/kanelloc/react-native-animated-header-scroll-view/pull/62