search

kaneplusplus / bigmemory

126 stars 24 forks source link

add function to convert float to int #108

Closed gmweaver closed 2 years ago

gmweaver commented 2 years ago

Fixes #107 to address errors in CRAN check (https://www.r-project.org/nosvn/R.check/r-release-macos-arm64/bigmemory-00check.html).

Adds functions to handle conversion to int when converting NumericVector to IntegerVector that align with Rccp definition of NA for IntegerVector.

agrueneberg commented 2 years ago

Just tried this on MacOS Builder (based on a checkout of 969bd9b11b9250270a2a2a842e8df24095d4ee5e with the patch applied) and it fixes the issue :+1:

gmweaver commented 2 years ago

@kaneplusplus @cdeterman do these changes look ok?

Hoping it is possible to release the fix before CRAN archive deadline on 2021-10-20.

agrueneberg commented 2 years ago

@kaneplusplus I would also appreciate some heads-up because it would be non-trivial for me to replace bigmemory.

kaneplusplus commented 2 years ago

@gmweaver and @agrueneberg Thanks for the pull request. I'm waiting on a new version of uuid to go to CRAN for the Windows build. I'm also going to email Uwe to let him know about the coordination in case it takes a little longer than expected. Right now I'm anticipating uploading to CRAN this weekend.