kanersps / essentialmode

A FiveM project
https://docs.kanersps.pw/docs/essentialmode
GNU Affero General Public License v3.0
82 stars 98 forks source link

High Hitch #79

Closed DarkNosS96-zz closed 4 years ago

DarkNosS96-zz commented 4 years ago

hello, I'm having very high hitches IMG_20200511_162810

Tinky124 commented 4 years ago

yea essentialmode have that problem.

kanersps commented 4 years ago

Actually if you have update there’s a toggle to disable position updates, however I don’t notice these issues.

Outlook voor iOShttps://aka.ms/o0ukef downloaden


Van: Tinky notifications@github.com Verzonden: Monday, May 11, 2020 4:18:33 PM Aan: kanersps/essentialmode essentialmode@noreply.github.com CC: Subscribed subscribed@noreply.github.com Onderwerp: Re: [kanersps/essentialmode] High Hitch (#79)

yea essentialmode have that problem.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/kanersps/essentialmode/issues/79#issuecomment-626730085, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC52CD42RBZ5FDRDGHMNBSTRRACLTANCNFSM4M56NSUQ.

DarkNosS96-zz commented 4 years ago

when I tried to download the latest update I had problem with spawn-respawn. on first spawn people spawned in the spawn point, but after they rejoin they spawned in the spawn point again instead of their last position. (I'm not using the latest es_extented, it's not working with my most script and I couldn't make them work with the new one)

DarkNosS96-zz commented 4 years ago

i copied the code part for update position and i disabled it, but now i cant teleport to players and when i join the server im down the map

kanersps commented 4 years ago

What kind of odd resources are you using that are utilizing these deprecated features?

DarkNosS96-zz commented 4 years ago

what do you mean?

kanersps commented 4 years ago

What resources do you use, that part of the code that sends the position is really old

Outlook voor iOShttps://aka.ms/o0ukef downloaden


Van: DarkNosS96 notifications@github.com Verzonden: Wednesday, May 13, 2020 9:52:56 PM Aan: kanersps/essentialmode essentialmode@noreply.github.com CC: kanersps kanepetra@gmail.com; Comment comment@noreply.github.com Onderwerp: Re: [kanersps/essentialmode] High Hitch (#79)

what do you mean?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/kanersps/essentialmode/issues/79#issuecomment-628210630, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC52CD3CQGG7P7UK7FBDFUTRRL3BRANCNFSM4M56NSUQ.

DarkNosS96-zz commented 4 years ago

im using many scripts, none of them is using the es:updatePositions

kanersps commented 4 years ago

Are any of them using .getCoords() ?

DarkNosS96-zz commented 4 years ago

yes, es_admin2 (to teleport) and es_extended on save player's position

kanersps commented 4 years ago

My assumption is that es_extended is using it too many times, which then create this. If you disabled the updateCoords event, is the tick time that high as well?

On Fri, 15 May 2020 at 22:44, DarkNosS96 notifications@github.com wrote:

yes, es_admin2 (to teleport) and es_extended on save player's position

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kanersps/essentialmode/issues/79#issuecomment-629474904, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC52CD2DSTM7ZGODZHF3LOTRRWSRPANCNFSM4M56NSUQ .

DarkNosS96-zz commented 4 years ago

you mean disable it from essentialmode or from es_extended? for essentialmode: it fix the high tick for es_extended: it will not save the coords for players and the save is happening every 15 minutes and when the players disconnecting, so i dont think this is triggering the essentialmode many times

kanersps commented 4 years ago

If you disable it, it means that that event is causing the tick issues. However I have it enabled and don't notice any issues whatsoever.

On Sat, 16 May 2020 at 11:22, DarkNosS96 notifications@github.com wrote:

you mean disable it from essentialmode or from es_extended? for essentialmode: it fix the high tick for es_extended: it will not save the coords for players and the save is happening every 15 minutes and when the players disconnecting, so i dont think this is triggering the essentialmode many times

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kanersps/essentialmode/issues/79#issuecomment-629615902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC52CD4DN3V2LUSG4WOPNLDRRZLPBANCNFSM4M56NSUQ .

DarkNosS96-zz commented 4 years ago

so the problem is from those two scripts (es_admin & es_extended) cuz they trigger this event many times?

DarkNosS96-zz commented 4 years ago

image

all those errors are from the latest version from this part

RegisterNetEvent('esx:playerLoaded')
AddEventHandler('esx:playerLoaded', function(xPlayer)
    ESX.PlayerData = xPlayer
    PlayerLoaded = true
end)
Tinky124 commented 4 years ago

yea i said that.. just do this @DarkNosS96 change:

RegisterNetEvent('esx:playerLoaded')
AddEventHandler('esx:playerLoaded', function(xPlayer)
    ESX.PlayerData = xPlayer
    PlayerLoaded = true
end)

to this:

RegisterNetEvent('esx:playerLoaded')
AddEventHandler('esx:playerLoaded', function(xPlayer)
    PlayerData = xPlayer
    PlayerLoaded = true
end)

I think it will fix your problem for now.. lol but to many errors or downgrade to 6.2.2 version es mode..

Issue #72

DarkNosS96-zz commented 4 years ago

i already using the 6.2.2 and im having those problems with high hitches

kanersps commented 4 years ago

Have you tried everything that @Tinky124 mentioned?

Tinky124 commented 4 years ago

@DarkNosS96 try use lastest version and try this above to fix errors

DarkNosS96-zz commented 4 years ago

I did it, I have latest version and I did the fix above, all working perfectly but still having high hitches. if I disable the position thing it will fix the high hitches but it don't save player's position, and when I teleport to them with es_admin2 I'm teleporting to the middle of the map

Tinky124 commented 4 years ago

@DarkNosS96 glad to hear that you fixed errors with above.. idk for hitch warnings..

kanersps commented 4 years ago

I'm not really sure how they could be caused, as I've never had these problems and can't reproduce them. However I advise changing the way that positions get saved if the current way is causing issues for you.