search

kanflo / opendps

Give your DPS5005 the upgrade it deserves
MIT License
895 stars 124 forks source link

cannot set voltage remotely via serial port #112

Closed coffinshaker closed 5 years ago

coffinshaker commented 5 years ago

When I remotely run the command to set voltage it returns "ok" but nothing changes. Shouldn't there be a line like this:

cv_voltage.value = ivalue;

just before calling the following function in line 162 in file func_cv.c:

voltage_changed(&cv_voltage);

or is there a reason the voltage cannot be changed this way?

kanflo commented 5 years ago

Hmm, I will try to reproduce (and fix ;) that this weekend. Thanks for reporting!

Xenoamor commented 5 years ago

Well spotted @coffinshaker!

coffinshaker commented 5 years ago

Glad I could help :) I thought that maybe it wasn't there for a reason but adding this line worked for me. Apart from that it's a nice piece of software. Thanks!

kanflo commented 5 years ago

Reminds me that I need to build an automated test environment in my basement :)