search

kangarko / Boss

Premium custom monsters plugin with skill system, natural spawning and lots of sickest features!
https://www.mc-market.org/resources/21619/
77 stars 28 forks source link

1.8.8: Lag Spike on Big Spawn Amount #1253

Closed IceGames23 closed 3 months ago

IceGames23 commented 3 months ago

Hello, I'm doing a horde event for my server and for this system I'm using /boss spawn for spawn bosses, but always when I spawn a lot of bosses, 50+ bosses, the server has a big lag spike, frezzing the server for some seconds and flooding console with boss spawn message. I want to know if that issue can be fixed.

kangarko commented 3 months ago

Please provide a spark report so we can properly investigate or any deeper reports.

IceGames23 commented 3 months ago

Here, I just spawned a horde and the tps down to 15 https://spark.lucko.me/yHLi5YGXWE

kangarko commented 3 months ago

Oh I see. You are on 1.8.8 which does not support persistent boss metadata so we have to write it to a file each time a boss spawns. For better performance use 1.16+ because Spigot added support for native metadata to entities. Unfortunately I dont see an easy way around this. Running it async will produce other issues.

IceGames23 commented 2 months ago

So I can't use my horde event because of that? Unfortunately I can't upgrade my server to 1.16+ too, because I will have to restructure all of my server, and my server it's a 1.8 pvp server too. You don't have a "difficult" way to solve this problem? All time when a player enter in a large region with "join spawn" rule this happens too.

I think if fix this will help other server owners that uses Boss in 1.8 too.

kangarko commented 2 months ago

Try the next version, I made a huge performance boost by only saving the metadata file on server stop/reload instead of each time it is used (i.e. each boss spawn)

IceGames23 commented 2 months ago

Perfect bro! I tested the newer version and now has 0 performance impact, thank you very much!

IceGames23 commented 2 months ago

Some other thing that I think can be really useful is a "silent" option in /boss spawn like "/boss spawn -s skeleton|skeleton|skeleton|skeleton|skeleton|skeleton|skeleton" because this can cause really anoying flood in console like that here.

image

Edit: More one thing, I saw the survey and please, centuries I'm looking for a good dungeon plugin that supports 1.8.8, I have a custom, but it's not really good. If your dungeon plugin support 1.8.8 that will be awesome, mainly for servers like mine, that it's unfortunately stuck in 1.8 because of the community. Countries in South America in general and some countries of Asia too it's "stuck" on 1.8 because of the "PvP community" and of people that hardwere don't support newer Minecraft versions, that people exists, and it's a huge the number, mainly in "third world countries".

kangarko commented 2 months ago

You can set the Commands.Spawn.Success message to "none" in the localization/messages_en.yml file to disable: https://i.imgur.com/h5Z72HJ.png

Yes, as a golden standard all of our plugins will work on Minecraft 1.7.10+!