kangarko / Boss

Premium custom monsters plugin with skill system, natural spawning and lots of sickest features!
https://www.mc-market.org/resources/21619/
77 stars 28 forks source link

1.16.5: Limit not working? Dangerous bug! #927

Closed SoraShiunin closed 2 years ago

SoraShiunin commented 2 years ago

I don't know why but limits are not working and mobs keep spawning(No errors). It took me a while to figure out why my server was constantly crashing, then I noticed there were 300 bosses in one place. Might be compatibility bug, not tested in an empty server. I am on boss 4.0.4

Boss.zip

This is havenzombie: Screenshot_2189 Screenshot_2190 Screenshot_2188

kangarko commented 2 years ago

Sorry I was not able to reproduce on a clean install: https://i.imgur.com/QGs6eTp.png

Set your Debug key to [spawning], remove all other bosses except for the troubled one you showed above (so that your console is not completely spammed and readable) and post me the debug log.

SoraShiunin commented 2 years ago

I believe its working properly(I don't know what happened then), I just had the same result. But after server restart 2 more spawned, no debug message about it in console. Screenshot_2262 Screenshot_2263

kangarko commented 2 years ago

What other plugins do you have? Could possibly be that Boss cannot recognize other entities as Bosses.

Or that the old Bosses get their chunks unloaded, such as when you walk away. Then the world really has 0 active entities and Boss will add 2 more.

SoraShiunin commented 2 years ago

The ones that I can think of that can interfere are maybe: MythicMobs, Towny and StackMob(It has an option so it doesn't interact with named mobs). Those are the ones that interact with mobs.

AntiAC, ConsoleSpamFix, PlayerHeads, LuckPerms, NBTEditor, ProtocolLib, AdvancedPortals, InventoryRollback, ccNoSpecTeleport, MultiverseHardcore, CleanroomGenerator, PlaceholderAPI, Runecraft, ItemEditor, SirBlobmanCore (SirBlobmanAPI, XSeries), Votifier, LibsDisguises, InfiniteVouchers, EpicGuard, NashornPlus, Vault, BKCommonLib, HolographicDisplays, Multiverse-Core, VotingPlugin, MovingDevApi, FastAsyncWorldEdit (WorldEdit), RPGHealthPlus, PlayerReferrals, ClientDetector, WorldGuard, Multiverse-Inventories, Essentials, WorldGuard-Towny, XPBoost, AdvancedRegionMarket, RewardPRO, ChatFeelings, SpectatorMode, CommandSigns, BetterJails, TAB, EssentialsSpawn, EnjinMinecraftPlugin, StackMob, Parties, NPCDestinations_Rancher, LWC, Quests, MythicMobs, NexEngine, WorldGuardExtraFlags, GoldenCrates, PhatLoots, Multiverse-NetherPortals, CombatLogX, AdvancedEnchantments, BanItem, MarriageMaster, CMILib, Jobs, UltimateShops, ActionHealth, SimplePets, Citizens, mcMMO, NPC_Destinations, Duels, QuestsGUI, Towny, WolfyUtilities, SuperVanish, CitizensText, TownyNameUpdater, CustomCrafting, Sentinel, TownyChat, Shopkeepers, SiegeWar, MobArena, DiscordSRV, MobArenaExtension, ProjectKorra, ProjectAddons, JedCore, Hyperion, Spirits, BendingGUI, Multiverse-Portals, PlayerParticles, ProCosmetics, RollbackCore, Boss, ExtraHardMode, CoreProtect, SurvivalGames, LightCleaner, Codex

If its relevant: Survival Games, Mobarenas, stuff like that is in other worlds.

kangarko commented 2 years ago

Try uninstalling MythicMobs and StackMob, if either is removing our NBT tag then we think there are no Bosses and spawn more.

SoraShiunin commented 2 years ago

Sorry I forgot I had a thing to prevent console spam and now that I tested on local I had this error spamming the console: https://pastebin.com/5dD8gwRf (I could not reproduce the respawning bug in local server with less plugins but this error happens)

I have two questions/bugs while testing. I thought the limit was per boss but its applying to all bosses(Via Spawn Rules)? Example: Boss1 has limit 1 Boss2 is spawned. Theres 1 boss in the server and its boss2. But boss1 cannot spawn since it reached limit of 1? (But there are no boss1 in the world)

Multiple bosses cannot spawn in the same location in the same spawn rule if one boss limit is reached. Will only spawn one boss type once a boss limit is reached of either mob.

SoraShiunin commented 2 years ago

So I was thinking of a suggestion to solve most if not all compatibility issues that may be related to the first "bug" posted. Since the bossess still appear in /boss find. Would it be possible to force despawn/kill bosses over a timeframe, if there are some over the limit?

kangarko commented 2 years ago

The error is likely caused by reloading or other error during startup, check for these. We will fix the limits in the next version. Thanks for reporting!