kangarko / ChatControl-Red

Issue tracker and documentation for the next generation ChatControl Red, the most advanced chat management plugin.
44 stars 22 forks source link

1.20.1: Command Packet Issue Again #2561

Closed gre3x closed 5 months ago

gre3x commented 5 months ago

"/version ChatControlRed" - plugin version

10.23.7

Are you using MySQL?

Yes

Are you using BungeeCord?

Yes

Error log (if applicable)

N/A

"/chc debug" output (strongly recommended)

https://github.com/kangarko/ChatControl-Red/files/14104550/debug.zip

Information about the issue/bug

Reopening since there was no response to my questions after the previous issue was closed.

I am assuming that clients can interact with backend server/spigot plugins and just because it is not processed on the proxy/bungee plugin, does not mean that the backend server/spigot plugin will not process the packet.

Again, this is happening on the backend/Spigot server, not the Proxy/Bungee.

Will toggling it off on the Bungee also block the interaction on Spigot servers? There is no toggle on the spigot servers to prevent this, so how do I block it on my spigot servers too?

And I also I just checked and I already had the Enable_Forward_Command to false on the Bungee sadly when this happened.

As a reminder for the previous report:

Players are able to execute console commands on the server they are currently on through custom clients by sending plugin message packets with the "FORWARD_COMMAND" argument and the server name is the same as the current server.

This is related to Bungee command forwarding, but the Bungee server is not involved I think. This all happens on the spigot server.

I do not have access to these clients or the exact code of how they are doing it, since these are being used my malicious players on my server and not by me, but here is what I think is close to an example of what a dangerous packet sent on an example "Hub1" server would look like:

There is no way to block these right now, even though I don't use the command forwarding feature.

Can you please add a way to disable processing these packets if we don't use the feature? Like if there is a FORWARD_COMMAND packet, then check a config option to see if command forwarding is enabled? Then we can disable it ourselves in the config

kangarko commented 5 months ago

Hello,

I receive notifications everywhere, and I have commented on the previous issue. It will be addressed tonight.