1.20.4: Breaking Change

[tavaresjoshua8]

"/version ChatControlRed" - plugin version

10.23.7

Are you using MySQL?

Yes

Are you using BungeeCord?

No

Error log (if applicable)

No response

"/chc debug" output (strongly recommended)

No response

Information about the issue/bug

This version has a change called "Patched stack overflow when attempting to parse variables inside variables", but it has completely broken my prefixes that used this same function.

Format Config:

[kangarko]

Apologizes for the delay. Please drop your /chc debug as per the issue template

[Timoti11]

me too!

[Timoti11]

@tavaresjoshua8

Hiii! I made a patch that fixes it: REMOVED

Here is script to apply patch on PS, it should be executed in the directory with plugin:

Invoke-WebRequest -Uri "https://gist.githubusercontent.com/Timoti11/189016ebae4d2600c508f2afd99d60aa/raw/4d85bee4f2fc3b542f5576eab562860ccbff719f/fix.patch" -OutFile .\fix.patch
Copy-Item .\ChatControl-Red-10.24.6.jar -Destination .\ChatControl-Red-10.24.6.zip
Expand-Archive .\ChatControl-Red-10.24.6.zip -DestinationPath .\ChatControl
Set-Location -Path .\ChatControl
git apply ..\fix.patch
Compress-Archive -Path .\** -DestinationPath ..\ChatControl-Red-10.24.6.fixed.zip
Set-Location -Path ..\
Rename-Item -Path .\ChatControl-Red-10.24.6.fixed.zip -NewName ChatControl-Red-10.24.6.fixed.jar
Remove-Item -Force -Recurse .\ChatControl

[tavaresjoshua8]

Nevermind, i fixed it using the "%utils_parse:num_placeholder%" placeholder, from the Utils Expansion.

[kangarko]

@Timoti11 please make a public pull request to the Variables class since it's a public class in Foundation: https://github.com/kangarko/foundation/releases

I have removed your link due to security concerns, would be hard for me to check the safety of your hack so please go the official way. If you need access to chatcontrol's source code just let me know.

[Timoti11]

@Timoti11 please make a public pull request to the Variables class since it's a public class in Foundation: https://github.com/kangarko/foundation/releases

I have removed your link due to security concerns, would be hard for me to check the safety of your hack so please go the official way. If you need access to chatcontrol's source code just let me know.

It's not the best solution to the issue - just hot fix for the moment

I just rolled back certain lines to make it work on my server today. All in all, I'll wait for a full-fledged fix

[kangarko]

We had to remove these lines since they opened a vulnerability where a certain scripted message would cause an infinite loop and crash the server. I am unaware of a better solution at the moment but I welcome your contributions.