search

kangarko / ChatControl-Red

Issue tracker and documentation for the next generation ChatControl Red, the most advanced chat management plugin.
43 stars 22 forks source link

1.20.1: Velocity Join/Leave/Switch Messages Nonexistent #2626

Closed OyotOnyenwe closed 2 months ago

OyotOnyenwe commented 3 months ago

"/version ChatControlRed" - plugin version

10.24.6

Are you using MySQL?

No

Error log (if applicable)

No response

"/chc debug" output (strongly recommended)

debug.zip

VelocityControl Config: velocitycontrol.zip

Information about the issue/bug

I've been trying to get VelocityControl to work since I switched to Velocity. I purchased ChatControl Red specifically to have access to VelocityControl. I previously used BungeeControl with ChatControl Free and had the desired behavior. I simply want a message that says "X joined the server" "X joined from otherServer" or "X left the server". I have configured the .rs files for velocitycontrol, but simply nothing appears when any player joins or quits the server. At one point I had only quit messages appearing, then those disappeared too. I don't know what changed to cause that.

kangarko commented 3 months ago

@james090500 mind having a look asap please?

Timoti11 commented 2 months ago

@kangarko This problem is also on BungeeControlRed - I used it for a year in conjunction with ChatControlRed - I had to put separately plugins like BungeeJoinMessages or vmessage. Here is my thread on this issue: https://github.com/kangarko/ChatControl-Red/issues/2403

james090500 commented 2 months ago

Are they completely non existent or just temperamental?

Timoti11 commented 2 months ago

Are they completely non existent or just temperamental?

It's not working. Sometimes after restart quit-message can work, but no other, and later it's finaly no message alerts

kangarko commented 2 months ago

Gotcha. I'll look into the protocol but looks like the packets are not being properly sent sometimes which is hard to debug. Will have a deeper look when I have time. @james090500 appreciated it you could had the time to debug chatcontrol too perhaps I made an error there and proxy is ok

james090500 commented 2 months ago

Gotcha. I'll look into the protocol but looks like the packets are not being properly sent sometimes which is hard to debug. Will have a deeper look when I have time. @james090500 appreciated it you could had the time to debug chatcontrol too perhaps I made an error there and proxy is ok

I wonder if it's caused by this @kangarko. I can't build and test right now but it lines up with the issues...

https://github.com/kangarko/ChatControl-Red-Src/commit/6c96e6b89abccd156359f4a787f50b2f9fcaee83#diff-17e33337e2804023492b18b97abcaa759560317f90e3cee53be40c2676c07904

kangarko commented 2 months ago

Which section of the commit? The synchronized lock?

james090500 commented 2 months ago

Which section of the commit? The synchronized lock?

In player listener. It's sending the packet as player, if the connection isn't fully established it may fail

kangarko commented 2 months ago

Which section of the commit? The synchronized lock?

In player listener. It's sending the packet as player, if the connection isn't fully established it may fail

Even before that commit we would still use the first available random player on the server since thats how bungee works if I am not mistaken.

@Timoti11 can you please try these two dev builds? you'd need to replace both chatcontrol and bungeecontrol using these builds:

Archive.zip

james090500 commented 2 months ago

Bungee/Velocity should be smart enough to use a player that's fully connected.

I'll try the dev build also and work on some more debugging my side

kangarko commented 2 months ago

Thanks. I removed synchronized/volatile blocks in the dev build. No other changes.

kangarko commented 2 months ago

@OyotOnyenwe can you please try the devbuild from above comment in case you're still having this issue?

OyotOnyenwe commented 2 months ago

I can't, because my issue was on VelocityControl and not BungeeControl. (I don't have a bungee proxy, only velocity)

kangarko commented 2 months ago

@james090500 can you please adjust velocitycontrol to the changes from bungee? Remove the synchronize blocks and replace volatile with final whereever possible

kangarko commented 2 months ago

@OyotOnyenwe can you try this alpha build of my version of velocity along with the next release of chatcontrol please? Thanks.

VelocityControl-1.0.0.zip

@james090500 see discord

Closing as I am taking over Velocity development now and believe this got fixed. Comment below if any issues.

OyotOnyenwe commented 2 months ago

Unfortunately the issue is still occurring. I have updated ChatControl to 10.25.6 on all my servers and installed the velocitycontrol build on the proxy. I double checked the bungee.yml for all of them, and updated the config for the new velocitycontrol plugin. Still absolutely nothing in the way of join, switch, or leave messages.

kangarko commented 2 months ago
  1. Just to confirm you used the ZIP file of velocity from above?
  2. Please use the v10.25.7 of ChatControl Red.
  3. If that problem still continues then set your Debug key in settings.yml of VelocityControl to [player-message] and post me the console log when join message should happen but it does not. Check it's enabled in settings.yml under Messages.Apply_On
OyotOnyenwe commented 2 months ago
  1. Yes, I'm using the new VelocityControl-1.0.0.jar and removed the old one.
  2. Updated to 10.25.7 ChatControl Red.
  3. Unfortunately the problem is still occurring. Attached is the console output. image Also, here is the Apply_On in velocitycontrol settings.yml: image
kangarko commented 2 months ago

Is chatcontrol installed on all spigot/paper servers with bungeecord enabled?

OyotOnyenwe commented 2 months ago

Yes, ChatControl is on all the servers and Bungee is enabled in the ChatControl config for each one. They all have the correct server-name field from server.properties, velocity config, VelocityControl config, and ChatControl config.

kangarko commented 2 months ago

Oh I apology, I missed that you said you had mysql off. You need to enable mysql in the mysql.yml file for network sync to work properly.

OyotOnyenwe commented 2 months ago

I don't want to use any of the other features like chatting across networks. I only wanted to have the join/leave/switch messages from VelocityControl and use ChatControl for moderation on each individual server. Is MySQL necessary for just that one feature?

kangarko commented 2 months ago

Should be fixed on my velocity build, closing. Let me know if you got any questions below.

kangarko commented 2 months ago

I am sorry but mysql is indeed required for fundamental data sync and its technically linked to sending other player data too required for player messages such as their statuses or variables.