kangarko / ChatControl-Red

Issue tracker and documentation for the next generation ChatControl Red, the most advanced chat management plugin.
43 stars 22 forks source link

1.20.4 : priority issue #2637

Closed WarnDa closed 2 months ago

WarnDa commented 2 months ago

"/version ChatControlRed" - plugin version

10.24.6

Are you using MySQL?

No

Are you using BungeeCord?

No

Error log (if applicable)

No response

"/chc debug" output (strongly recommended)

debug.zip

Information about the issue/bug

Since some months (at least 2 months) the priority system is getting issue.

Before I was using Chat_Listener_Priority: LOWEST without issue, didn't update any plugin except chatcontrolred, and now I'm getting tons of issues with every plugin that use chat :

Before I had litterally no issue. I tried changing to each possible value (from lowest to monitor) none of them work properly without creating issue.

The issue seems to occur since I updated from 1.19 to 1.20 (same on 1.20.1 server), because I had to update chatcontrol when I updated my server version, and after this, the issue happened

WarnDa commented 2 months ago

Every plugin that need to CANCEL a chat event can't. (tested ALL priority) Each time the message is still send. This didn't happen before on 1.19

kangarko commented 2 months ago

Can you try switching value of Channels.Alternative_Console_Sending in settings.yml?

WarnDa commented 2 months ago

Can you try switching value of Channels.Alternative_Console_Sending in settings.yml?

It's the same behavior, but some plugin messages are canceled but they shouldn't (like superior ones), tried on all priority

kangarko commented 2 months ago

Can you please give me step-by-step instructions on how to reproduce using one of the above (free) plugins? I assume you're on stock Paper not Purpur etc.

kangarko commented 2 months ago

I see you're on UniverseSpigot. Can you please try using Paper - just to be 100% sure that the fork is not the one causing this? I don't have the time capacity to test on all forks, thanks for your understanding.

WarnDa commented 2 months ago

I could reproduce the issue and find more informations ! It's something from the config, as with default chatcontrol I don't get any issue, but with the config on the /chc debug I got issue

For this test I had to use a premium plugin (easier for me) add me on discord : warnd I'll give it to you Plugin used : https://www.spigotmc.org/resources/%E2%AD%90-player-warps-%E2%AD%90-%E2%9E%A2-let-your-players-set-warps-1-7-1-20-4.115286/ Dependency : https://www.spigotmc.org/resources/vault.34315/

Edit : If I set "channel" to Enabled: false the issue is fixed, so it comes from channels (a bit logical lol)

kangarko commented 2 months ago

The message always shows up for me. Even when chatcontrol is uninstalled:

Screenshot 2024-04-12 at 13 42 40

Sorry I believe either these plugins are not canceling chat event properly or there is some other bug out of chatcontrol's scope. In us, simply by changing the priority to HIGHEST or MONITOR majority of issues are fixed.

Or, 1.20 changed something in the event pipeline - had I been you I would ask that in paper discord just to be sure. Praying they didnt since that would be unfixable on our end.

kangarko commented 2 months ago

Feel free to continue talking below

WarnDa commented 2 months ago

The message always shows up for me. Even when chatcontrol is uninstalled:

Screenshot 2024-04-12 at 13 42 40

Sorry I believe either these plugins are not canceling chat event properly or there is some other bug out of chatcontrol's scope. In us, simply by changing the priority to HIGHEST or MONITOR majority of issues are fixed.

Or, 1.20 changed something in the event pipeline - had I been you I would ask that in paper discord just to be sure. Praying they didnt since that would be unfixable on our end.

Because you tested the free version, that has issue, on the premium version I was able to correctly reproduce the issue.

Here is with HIGHEST priority : image debug.zip

And MONITOR : image debug.zip

And if I remove chatcontrol channels, no issue.

kangarko commented 2 months ago

I am not able to test with premium plugins. Is any one of those four above available as a free one?

kangarko commented 2 months ago

Or contact me privately at matej@mineacademy.org and we can move forward with this faster.