kangarko / ChatControl-Red

Issue tracker and documentation for the next generation ChatControl Red, the most advanced chat management plugin.
43 stars 22 forks source link

Do not be so strict on MC server version <-> Java version #2676

Closed TheJoshue closed 1 month ago

TheJoshue commented 1 month ago

Summary

This is what happens when i run 1.12.2 server on Java11

[00:35:36] [Server thread/INFO]: [ChatControlRed] Loading ChatControlRed v10.25.10
[00:35:36] [Server thread/INFO]: [ChatControlRed] !-----------------------------------------------------!
[00:35:36] [Server thread/INFO]: [ChatControlRed]  Warning: Unsupported Java version: 11 for your server
[00:35:36] [Server thread/INFO]: [ChatControlRed]  version! Minecraft 1.12.2 was designed for Java 8
[00:35:36] [Server thread/INFO]: [ChatControlRed]  and we're unable unable to load 'legacy-libraries'
[00:35:36] [Server thread/INFO]: [ChatControlRed]  that this plugin uses:
[00:35:36] [Server thread/INFO]: [ChatControlRed]  org.slf4j, org.slf4j, com.zaxxer, org.mariadb.jdbc, com.mysql
[00:35:36] [Server thread/INFO]: [ChatControlRed]  
[00:35:36] [Server thread/INFO]: [ChatControlRed]  To fix this, start your server using Java 8 or
[00:35:36] [Server thread/INFO]: [ChatControlRed]  upgrade to Minecraft 1.16 or greater.
[00:35:36] [Server thread/INFO]: [ChatControlRed] !-----------------------------------------------------!

What would happen if we didn't implement this feature? Why not having this feature is a problem?

I will soon upgrade my server to use Dionysus fork for 1.12.2 because i need to keep 1.12.2, and it will run on Java17 because i need it for other plugins

I personally think this isreally not ok to limit us with ever so specific mc versions that work with ever so specific java versions, please... it was great until you added this... just don't care, send a message to console that for 1.8-1.16 it is recommended java 8, etc... but do not add checks, please...

Thank you in advance...

kangarko commented 1 month ago

It's not that we are strict and set arbitrary limitations, we are unable to handle library loading on that version with that java version.

Install LibraryHelper as a plugin and it should work. Ignore that warning, I will remove it in the next version.