kangarko / ChatControl-Red

Issue tracker and documentation for the next generation ChatControl Red, the most advanced chat management plugin.
49 stars 23 forks source link

Packet flooding client #415

Closed Yamamot00 closed 3 years ago

Yamamot00 commented 3 years ago

Im having a issue on the Clientside when a player teleports to another server the Minecraft Log starts to spam one text

Text is : [Render thread/WARN] [minecraft/ClientPlayNetHandler]: Unknown custom packet identifier: plugin:chcred Photo: http://prntscr.com/wcdm1s

to reproduce this step i need to log in with another account

  1. Player *steve Enters the server Lobby
  2. Player *giraffe teleports to Another server
  3. *Steve Log start to show this text on his Minecraft Log
  4. *giraffe doesn't occour anything on his Minecraft Log

Edit: Actually i tried doing other commands from the chatcontrol-red and it also started showing that text on the minecraft Log.

the command that i issued was /chc debug (for precautions for if i needed to send the debug file when someone replies this issue) and then it started to spam this text again on the Log

Chatcontrol-red: 10.1.11 Minecraft Version: Paper-1.16.4 MySQL: true BungeeCord: false

this packet spam only shows on the Client, the server isn't complaining about anything Im using MultiMC to enter with my accounts to test the plugins as a Normal member and Admin

kangarko commented 3 years ago

This has to be caused by some security means either on your server or by an "exploit fixer" plugin which triggers these false positives. Try without other plugins or try increasing some packet limitation in paper.yml or spigot.yml, by increasing incoming-packet-spam-threshold.

Yamamot00 commented 3 years ago

This has to be caused by some security means either on your server or by an "exploit fixer" plugin which triggers these false positives. Try without other plugins or try increasing some packet limitation in paper.yml or spigot.yml, by increasing incoming-packet-spam-threshold.

Im sorry the problem still persist. i Changed my servers spigot.yml incoming-packet-spam-threshold from 300 to 500/1000/1300 and the problem still persist.

i also Disabled a plugin that prevent malicious packet from crashing the server and nothing happened, the plugin was SpigotGuard

and i dont have any other plugin that handles packets other than this plugin, or ProtocolLib perhaps.

Could you Help me on how to fix this? actually i dont even understand why my client is showing that message on the log for me to get an idea on what i should do to fix it

edit: this has never happened to me before, even on the Chatcontrol-pro this message didn't showed on the log

ElBananaa commented 3 years ago

This has to be caused by some security means either on your server or by an "exploit fixer" plugin which triggers these false positives. Try without other plugins or try increasing some packet limitation in paper.yml or spigot.yml, by increasing incoming-packet-spam-threshold.

Im sorry the problem still persist. i Changed my servers spigot.yml incoming-packet-spam-threshold from 300 to 500/1000/1300 and the problem still persist.

i also Disabled a plugin that prevent malicious packet from crashing the server and nothing happened, the plugin was SpigotGuard

and i dont have any other plugin that handles packets other than this plugin, or ProtocolLib perhaps.

Could you Help me on how to fix this? actually i dont even understand why my client is showing that message on the log for me to get an idea on what i should do to fix it

edit: this has never happened to me before, even on the Chatcontrol-pro this message didn't showed on the log

Hey! Happy New Year!

A few people have already reported this, and they all have a packet-limiter plugin (Either SpigotGuard, ExploitFixer or any other packet-limiter). AFAIK, There's nothing Kangarko could do to fix this. However, you can try to contact SpigotGuard author, and ask them to add an exception for the plugin channel "plugin:chcred"

Yamamot00 commented 3 years ago

This has to be caused by some security means either on your server or by an "exploit fixer" plugin which triggers these false positives. Try without other plugins or try increasing some packet limitation in paper.yml or spigot.yml, by increasing incoming-packet-spam-threshold.

Im sorry the problem still persist. i Changed my servers spigot.yml incoming-packet-spam-threshold from 300 to 500/1000/1300 and the problem still persist. i also Disabled a plugin that prevent malicious packet from crashing the server and nothing happened, the plugin was SpigotGuard and i dont have any other plugin that handles packets other than this plugin, or ProtocolLib perhaps. Could you Help me on how to fix this? actually i dont even understand why my client is showing that message on the log for me to get an idea on what i should do to fix it edit: this has never happened to me before, even on the Chatcontrol-pro this message didn't showed on the log

Hey! Happy New Year!

A few people have already reported this, and they all have a packet-limiter plugin (Either SpigotGuard, ExploitFixer or any other packet-limiter). AFAIK, There's nothing Kangarko could do to fix this. However, you can try to contact SpigotGuard author, and ask them to add an exception for the plugin channel "plugin:chcred"

happy new year

Yep, but just like i said, i disabled the SpigotGuard plugin before i tested increasing the icoming-packets, i also dont have ExploitFixer installed on my server soo. No clue on why this is happening

edit: Could you forward me to the other issues that have the same problem as mine? maybe i can try reading then and think of a way

ElBananaa commented 3 years ago

Sorry, I was confused, actually, afaik no one else reported this issue. Make sure your plugins and their dependencies are all up-to-date. Also make sure that your server/proxy softwares are up-to-date. Let me know if it still persists, even after that, and if so, I'll reopen the issue.

Yamamot00 commented 3 years ago

No problem, The Chatcontrol-red are in the latest version (10.1.14) and the others plugins are also up to date. to be fair I have a issue on the Paper-1.16.4 saying that I have to update the JDK to 11 since I'm using the 7, but I cant do that because the Host that I'm using is a Cheap one and I cant suggest that by the price I'm paying haha(will change host when server is ready). but I don't think the java is the problem

ElBananaa commented 3 years ago

No problem, The Chatcontrol-red are in the latest version (10.1.14) and the others plugins are also up to date. to be fair I have a issue on the Paper-1.16.4 saying that I have to update the JDK to 11 since I'm using the 7, but I cant do that because the Host that I'm using is a Cheap one and I cant suggest that by the price I'm paying haha(will change host when server is ready). but I don't think the java is the problem

Well, if paper staff told you that this is a reason, there's a high chance this is the actual reason. I don't know which hosting company your are using, but you should consider upgrade as fast as possible if they're still using java 7. This version is deprecated since more than 3 years. All plugins are compiled under java 8+ now.

Yamamot00 commented 3 years ago

Oh yes, I forgot to mention that i also tested with spigot-1.16.4 with no errors on console about jdk and i also received the problem

Im running 1 proxy and 2 servers btw

Yamamot00 commented 3 years ago

No problem, The Chatcontrol-red are in the latest version (10.1.14) and the others plugins are also up to date. to be fair I have a issue on the Paper-1.16.4 saying that I have to update the JDK to 11 since I'm using the 7, but I cant do that because the Host that I'm using is a Cheap one and I cant suggest that by the price I'm paying haha(will change host when server is ready). but I don't think the java is the problem

Well, if paper staff told you that this is a reason, there's a high chance this is the actual reason. I don't know which hosting company your are using, but you should consider upgrade as fast as possible if they're still using java 7. This version is deprecated since more than 3 years. All plugins are compiled under java 8+ now.

i will try to recreate my servers on a localhost and update you

Yamamot00 commented 3 years ago

SO here it is: i made a local server for myself with only the basic of the basic plugins like LuckPerms/Skinrestorer/ProtocolLib and finally chatcontrol. I used the same settings and format that i used on my main server Both on the BungeeCord and TestServer. Connected to MySQL db the Lkperms and Chatcontrol. Both in a separate database

with my settings: result=>[Render thread/WARN]: Unknown custom packed identifier: plugin:chcred tried increasing the incoming-packet-spam: result=>[Render thread/WARN]: Unknown custom packed identifier: plugin:chcred Tried with a Brand new Settings.yml result=> no packet flood on Client!! yay Tried with Brand new settings.yml--Bunge on "true" result=>[Render thread/WARN]: Unknown custom packed identifier: plugin:chcred

so in conclusion i could understand that when i activate Bungeecord to True on Chatcontrol-Red the Client start to spam this message on his Client Log. Is There anything i could do to stop this? i dont want my client log to be spaming this error message

i could give you a copy of my test servers if you want to test on yourself

ElBananaa commented 3 years ago

SO here it is: i made a local server for myself with only the basic of the basic plugins like LuckPerms/Skinrestorer/ProtocolLib and finally chatcontrol. I used the same settings and format that i used on my main server Both on the BungeeCord and TestServer. Connected to MySQL db the Lkperms and Chatcontrol. Both in a separate database

with my settings: result=>[Render thread/WARN]: Unknown custom packed identifier: plugin:chcred tried increasing the incoming-packet-spam: result=>[Render thread/WARN]: Unknown custom packed identifier: plugin:chcred Tried with a Brand new Settings.yml result=> no packet flood on Client!! yay Tried with Brand new settings.yml--Bunge on "true" result=>[Render thread/WARN]: Unknown custom packed identifier: plugin:chcred

so in conclusion i could understand that when i activate Bungeecord to True on Chatcontrol-Red the Client start to spam this message on his Client Log. Is There anything i could do to stop this? i dont want my client log to be spaming this error message

i could give you a copy of my test servers if you want to test on yourself

Hey!

You'll have to wait for Kangarko to see what can be done.

kangarko commented 3 years ago

Never heard of that message "Unknown custom packed identifier" unfortunately, we only have one ticket like that that is many months old and it went away on its one.

I do suggest you use Java at least 11, seventh version is absolutely unsupported. Wouldn't be surprised if it goes away after upgrading.

Yamamot00 commented 3 years ago

sorry to inform you but the servers are all uptdate to java 11, i contacted the host owners and they put in java 11

still same problem, this only ocours when i enable BungeeCord on the Chatcontrol settings. even with a brand new settings, when i enable the bungeecord the same problem happens

kangarko commented 3 years ago

Try updating BungeeCord or using Waterfall, eventually asking their developers, as I said unfortunately I can't help with this since we don't print that message out at all

Yamamot00 commented 3 years ago

well in the console itself doesnt show anything suspicius but if you try to look in %appdata%/.minecraft/logs/latest.txt you can see that it spam this message

im not using any Fork of Bungee or spigot. i simply configured on my test server to use Original(Bungeecord/spigot) and enabled the Chatcontrol/bungeecord feature to "true" to make my client spam this message about your plugin

I unfortunately deactivated the Bungeecord feature from your plugin, the client log is very important for myself

maybe this problem is similar to #346 the plugin is flooding the Bungeecord server and the User client log when the Bungeecord is enabled. i think the only way to fix my issue is to fix his issue

kangarko commented 3 years ago

Please continue on 346 and send me your /chc debug ZIP file. I'm interested especially in the data.db file.