kangarko / ChatControl-Red

Issue tracker and documentation for the next generation ChatControl Red, the most advanced chat management plugin.
49 stars 23 forks source link

1.16.5 - /list does nothing #949

Closed cayoten closed 3 years ago

cayoten commented 3 years ago

Minecraft Version: 1.16.5 MySQL: true BungeeCord: true

Uh, idk what happened but /list just does nothing now. Running Purpur 1.16.5 (No difference if using Paper, idk why y'all give a warning...) My files are attached here: https://ufile.io/n2uf7m7h

ElBananaa commented 3 years ago

Minecraft Version: 1.16.5 MySQL: true BungeeCord: true

Uh, idk what happened but /list just does nothing now. Running Purpur 1.16.5 (No difference if using Paper, idk why y'all give a warning...) My files are attached here: https://ufile.io/n2uf7m7h

Hey! I'm also using purpura and the latest version of chatcontrol, and the /list command works perfectly fine for me. Could you please try to update all your other plugins and dependencies, and also your server software, then try again. We also had trouble with plugins such as ExploitFixer in the past, however, it doesn't mean that this is the cause of your issue. Anyways, if the issue persists, try to reproduce it under local setup with only plugins such as ChatControl, vault, luckperms and ProtocolLib installed.

Regarding the warn, even tho the plugin is stable, keep in mind that forks like tuinity (on which purpur is based) can sometime make some breaking changes. Since Kangarko doesn't have time to make sure every feature works under these forks, he added this warn, so people using forks are aware that their issues can possibly be caused by their forks.

cayoten commented 3 years ago

I just downloaded a local version of the server & followed your steps, trying to remove EF and then finally all plugins except the ones you said - however, I still have the same issue. Moving from Purpur to Paper gives the the same result.

cayoten commented 3 years ago

Is it worth noting that CHC 10.3. something like 2 updates ago worked, but this doesn't?

TheIntolerant commented 3 years ago

I believe there was a change to /list in the last update, to hide vanished players, could this have caused this bug?

cayoten commented 3 years ago

I believe there was a change to /list in the last update, to hide vanished players, could this have caused this bug?

This could very well be possible, but I do not give all of my members vanish permissions LOL

Current plugins: image

TheIntolerant commented 3 years ago

just going to mention the ticket, so people know what I'm referring too #936

TheIntolerant commented 3 years ago

The changes made to how /list works regarding hidden players, was on the 10.3.7 release, it might be worth seeing if this issue is present on 10.3.6 and then testing again on the latest version.

cayoten commented 3 years ago

It does not appear to work in 10.3.6.

kangarko commented 3 years ago

What do you mean "it does nothing"? Can you post a screenshot of that command's output?

cayoten commented 3 years ago

https://user-images.githubusercontent.com/57970060/116917120-dc946180-ac13-11eb-873b-513cc76bd08d.mp4 Typing /list literally just gives no response - it shows I typed /list in console but nothing happens at all. Recording above.

cayoten commented 3 years ago

image

https://user-images.githubusercontent.com/57970060/116917120-dc946180-ac13-11eb-873b-513cc76bd08d.mp4 Typing /list literally just gives no response - it shows I typed /list in console but nothing happens at all. Recording above.

ElBananaa commented 3 years ago

image

https://user-images.githubusercontent.com/57970060/116917120-dc946180-ac13-11eb-873b-513cc76bd08d.mp4 Typing /list literally just gives no response - it shows I typed /list in console but nothing happens at all. Recording above.

Well, since I can't reproduce this on my own prod server, on a local test server, and on my "official" test server, I guess this is somehow related to your bungee setup. Are you sure you modified the files on the right server? Also, could you please provide us you configs from your other server(s) and your proxy?

Also, (I don't really know if this could help), but make sure the plugin is correctly setup on each server, and same thing for BungeeControl. BTW, are you using Bungeecord/waterfall, or anything else?

cayoten commented 3 years ago

Here's all 4, including my proxy's settings file: (I was still having that issue where tab completion sometimes didn't work but that's a different issue, idk if this is related at all but here's all configs for this bug) https://ufile.io/f/47on0

ElBananaa commented 3 years ago

Here's all 4, including my proxy's settings file: (I was still having that issue where tab completion sometimes didn't work but that's a different issue, idk if this is related at all but here's all configs for this bug) https://ufile.io/f/47on0

Thanks. Did you defined a diferent server name for each server in your server.properties? Tbho I have absolutely no idea of what's causing your issue...

cayoten commented 3 years ago

I did.

Here's all 4, including my proxy's settings file: (I was still having that issue where tab completion sometimes didn't work but that's a different issue, idk if this is related at all but here's all configs for this bug) https://ufile.io/f/47on0

Thanks. Did you defined a diferent server name for each server in your server.properties? Tbho I have absolutely no idea of what's causing your issue...

ElBananaa commented 3 years ago

I did.

Here's all 4, including my proxy's settings file: (I was still having that issue where tab completion sometimes didn't work but that's a different issue, idk if this is related at all but here's all configs for this bug) https://ufile.io/f/47on0

Thanks. Did you defined a diferent server name for each server in your server.properties? Tbho I have absolutely no idea of what's causing your issue...

Is your bungeecontrol up-to-date? And finally, what's your proxy software? BungeeCord, Waterfall, or anything else?

cayoten commented 3 years ago

I did.

Here's all 4, including my proxy's settings file: (I was still having that issue where tab completion sometimes didn't work but that's a different issue, idk if this is related at all but here's all configs for this bug) https://ufile.io/f/47on0

Thanks. Did you defined a diferent server name for each server in your server.properties? Tbho I have absolutely no idea of what's causing your issue...

Is your bungeecontrol up-to-date? And finally, what's your proxy software? BungeeCord, Waterfall, or anything else?

Using FlameCord 0.5.0, all of the servers are running the latest version, 10.3.8.

ElBananaa commented 3 years ago

I did.

Here's all 4, including my proxy's settings file: (I was still having that issue where tab completion sometimes didn't work but that's a different issue, idk if this is related at all but here's all configs for this bug) https://ufile.io/f/47on0

Thanks. Did you defined a diferent server name for each server in your server.properties? Tbho I have absolutely no idea of what's causing your issue...

Is your bungeecontrol up-to-date? And finally, what's your proxy software? BungeeCord, Waterfall, or anything else?

Using FlameCord 0.5.0, all of the servers are running the latest version, 10.3.8.

That might be the reason actually. Could you try to temporary replace FlameCord with BungeeCord or Waterfall?

cayoten commented 3 years ago

sure! also, is it worth noting that bcred logs this to my console? these are the join quit switch servers etc, its rly odd.

13:29:30 INFO: [Dovur] disconnected with: ReadTimeoutException : null

ElBananaa commented 3 years ago

sure! also, is it worth noting that bcred logs this to my console? these are the join quit switch servers etc, its rly odd.

13:29:30 INFO: [Dovur] disconnected with: ReadTimeoutException : null

Well, regarding the disconnect message, this is completely normal. Regarding the other messages, I guess these are just info messages. Maybe @kangarko could add an option to disable them (Like the Show_Tips config in CHC-Red config file)?

cayoten commented 3 years ago

Using Waterfall gives me no difference.

cayoten commented 3 years ago

Would you actually want to like, connect to my server and try to figure this out with me?

ElBananaa commented 3 years ago

I am even able to give you view & read permissions to SFTP files & I have the backups to prevent damage of course

No, this won't be necessary, but thanks. I'd rather let Kangarko do this if this is actually needed, since I don't think this is my role to ask people access to their server files (Even tho I won't do anything).

Would you actually want to like, connect to my server and try to figure this out with me?

I mean, if you want, but I don't really think of anything more I could do there ^^

cayoten commented 3 years ago

I could at least demonstrate what I mean with the "doing nothing" as a visual example.

I am even able to give you view & read permissions to SFTP files & I have the backups to prevent damage of course

No, this won't be necessary, but thanks. I'd rather let Kangarko do this if this is actually needed, since I don't think this is my role to ask people access to their server files (Even tho I won't do anything).

Would you actually want to like, connect to my server and try to figure this out with me?

I mean, if you want, but I don't really think of anything more I could do there ^^

ElBananaa commented 3 years ago

I could at least demonstrate what I mean with the "doing nothing" as a visual example.

I am even able to give you view & read permissions to SFTP files & I have the backups to prevent damage of course

No, this won't be necessary, but thanks. I'd rather let Kangarko do this if this is actually needed, since I don't think this is my role to ask people access to their server files (Even tho I won't do anything).

Would you actually want to like, connect to my server and try to figure this out with me?

I mean, if you want, but I don't really think of anything more I could do there ^^

I understood what your meant in your video. The weird thing is that the plugin actually recognizes the command since it gave you this output : [ChatControlRed 10.3.8] Command /list took xx.xx ms But yeah, if you want we can give it a try seeing it by myself (or even trying to use /list as a default user)

cayoten commented 3 years ago

Doing /list as a default user warns of them not having the permission. Giving them the permission shows the same thing to me (nothing.)

cayoten commented 3 years ago

I'm just insanely confused if this is a bug or a screw up with the config files, or what.

ElBananaa commented 3 years ago

Doing /list as a default user warns of them not having the permission. Giving them the permission shows the same thing to me (nothing.)

That's a very strange behavior yes. So I guess it's either caused by one of your other plugins (actually, that's very unlikely), by a config issue, or because your servers are under a proxy.

Your configs are all looking fine to me. Same for the localization files. If your localization files are the default ones, you could try to stop all your servers, removing your /plugins/ChatControlRed/localization/messages_en.yml from each server, then starting back your server. Even tho I don't see anything wrong there, who know...

cayoten commented 3 years ago

this is gonna sound insane but i just tried an old server backup with 10.3.5 (local download, no proxy) and it didn't work but i had a random user test with me and its also broken. my brain hurts too much man.

cayoten commented 3 years ago

this has to be a bungee issue, right?

ElBananaa commented 3 years ago

this has to be a bungee issue, right?

I guess it is yeah. Unfortunately I can't try since my proxy is running under Velocity. Let's wait for Kangarko to have a look at it. In the meantime, as a temp fix, I can only suggest you disable CHC-Red List feature until it gets fixed ^^

cayoten commented 3 years ago

this has to be a bungee issue, right?

I guess it is yeah. Unfortunately I can't try since my proxy is running under Velocity. Let's wait for Kangarko to have a look at it. In the meantime, as a temp fix, I can only suggest you disable CHC-Red List feature until it gets fixed ^^

I FOUND THE ISSUE

IT IS DEFINITELY AN UPDATE

Rolling BOTH servers (ALL 3 servers and proxy) back to 10.3.5 makes list work again.

ElBananaa commented 3 years ago

this has to be a bungee issue, right?

I guess it is yeah. Unfortunately I can't try since my proxy is running under Velocity. Let's wait for Kangarko to have a look at it. In the meantime, as a temp fix, I can only suggest you disable CHC-Red List feature until it gets fixed ^^

I FOUND THE ISSUE

IT IS DEFINITELY AN UPDATE

Rolling BOTH servers (ALL 3 servers and proxy) back to 10.3.5 makes list work again.

Pretty weird. So yeah, it's probably somehow related to an update and to bungeecord and/or to the vanish. Since the only change we're aware of is the Vanish support in the /list which was added in 10.3.7

kangarko commented 3 years ago

sure! also, is it worth noting that bcred logs this to my console? these are the join quit switch servers etc, its rly odd.

13:29:30 INFO: [Dovur] disconnected with: ReadTimeoutException : null

Sorry about these messages, they are just a forgotten debug log and I will remove them in the next release.

this has to be a bungee issue, right?

I guess it is yeah. Unfortunately I can't try since my proxy is running under Velocity. Let's wait for Kangarko to have a look at it. In the meantime, as a temp fix, I can only suggest you disable CHC-Red List feature until it gets fixed ^^

I FOUND THE ISSUE

IT IS DEFINITELY AN UPDATE

Rolling BOTH servers (ALL 3 servers and proxy) back to 10.3.5 makes list work again.

Apologies for a delayed response. Did you just rolled ChatControl back or the whole server? It looks like something else is interfering here.

I recommend you do a two-step testing: first, just use a local desktop MC server without bungee to literally copy-paste your ChatControl setup there without any other plugins, just disable bungeecord and try the command... then add in bungee and try again. I am curious if there's maybe another plugin causing this (I know we discussed this but Banana said to keep ProtocolLib etc.)

cayoten commented 3 years ago

I had rolled back all CHC plug-ins (including Bungee) to 10.3.5 and it has fixed it. I kept the configs when I rolled back.

kangarko commented 3 years ago

Got it... looks like there was a change elsewhere, not 100% sure but pretty certain.

Please do the two-step reproduction I instructed above, I know it's gonna take 20 mins but it'll help us.

Also when you're still on the rolled-back version, try ONLY updating ChatControl Red and BungeeControl Red on that old backup.

cayoten commented 3 years ago

It does appear to be BungeeCord related - if I turn bungee off on my local server, /list works. Let me supply you with all of my BungeeCord plugins: image

kangarko commented 3 years ago

It must be caused by one of these plugins. If you had removed all of them except BungeeControl Red it would work, try disabling them one-by-one until you find the one that's causing it.

cayoten commented 3 years ago

But this doesn’t make any sense - 10.3.5 works with these plugins.

cayoten commented 3 years ago

@kangarko I attempted to remove all plugins BUT BungeeControl and it still doesn't work.

cayoten commented 3 years ago

What else could this POSSIBLY be?

kangarko commented 3 years ago

I will check the code change history since 10.3.5. Can you test with 10.3.6 just in case?

cayoten commented 3 years ago

@kangarko I was just able to confirm that version 10.3.6 is working.

kangarko commented 3 years ago
Screenshot 2021-05-14 at 13 23 51

Sorry to bother you with this, but since I absolutely cannot reproduce, please allow me to at least range down in which release the issue lays — could you test 10.3.7 and 10.3.8 as well and report when it does stop working?