kangarko / CoreArena

A high-end monster arena Minecraft plugin with procedural damage and RPG system. Maps included!
https://www.mc-market.org/resources/21643/
30 stars 12 forks source link

1.21.1 instantly ending rounds #538

Open sennby opened 1 week ago

sennby commented 1 week ago

{8AC2C67F-CB90-4A58-9816-0C337F1973E9}

Since updating to 1.21.1 my "dungeons" dont end when mobs are dead now. they end instantly, so the dungeons get joined, and all rounds run through instantly, all mobs are still there and spawn properly, but the dungeon cant be done because of the instant rounds and the dungeon ending when done.

kangarko commented 1 week ago

Can you please send me the arena .yml file? Just that one.

sennby commented 1 week ago

Can you please send me the arena .yml file? Just that one.

https://mclo.gs/UQHoLvl

kangarko commented 1 week ago

Let me get back to you in 24 hours

kangarko commented 1 week ago

Sorry unfortunately I had to delay it, but I should be finally sitting down this weekend.

kangarko commented 1 week ago

Sorry I cannot reproduce. The next phase is only activated, after I kill the MythicMobs boss. Can you try removing all other plugins except MythicMobs to exclude possible conflicts?

sennby commented 1 week ago

Moreso i think this is an issue with it detecting the mobs it uses as they are bees. Other ones of my dungeons work with custom mobs but i know these bees use bees.

kangarko commented 1 week ago

Super-strange. Can you test with a Zombie-type or any other more standard mob? I will have time to test with Bees tomorrow.

sennby commented 1 week ago

Super-strange. Can you test with a Zombie-type or any other more standard mob? I will have time to test with Bees tomorrow.

so now.. i cannot even get the arena to start lol. I edited the arena added a couple zombie eggs, re-enabled the arena (its been off on my server bc broke) now it just sends the player to the lobby then keeps them there and the lobby isnt starting. in console i see a arena ended message right after they type the command to join.

sennby commented 1 week ago

image

So now i just pulled from my 1.20.4 server the beehivedungeon, reloaded. dungeon was able to start. When i joined, all of the mythicmobs were spawned it looked like from all the spawners (the bees) along with ONE zombie (it was round 1 or 2) so the zombies were spawning properly. it didnt go past phase 2 since the zombie was alive.

weird part: After about 10 seconds everything in the dungeon died other than the zombie.

sennby commented 1 week ago

More testing:

if i sit in the lobby for more than a few seconds the dungeon seems to stop but you remain in the lobby. i can just spawn /dg join BeeHiveDungeon . If i do a /dg start quickly, it starts the dungeon. all bees are spawned, 10 seconds go by then the bees (all the mythicmobs) die.

kangarko commented 1 week ago

Might be a third party plugin incompatibility even, can you please upload your /arena debug so I can have a look?

sennby commented 1 week ago

I can tell you this exact setup works on my 1.20.4 with just about the same everything minus a few small things like lifesteal vs griefprevention.

debug.zip

kangarko commented 1 week ago

Turns out Bee class has been internally moved from Creature to Animals. I have added a manual override which should fix that, thank you!

sennby commented 6 days ago

Issue still remains. however it is different:

the bees are recognized now it would seem. however they all mass die after about 10 seconds of existing, then the next round starts, repeat. However at round 5 (boss round) the bees seem to stay alive... and the boss as well.

sennby commented 6 days ago

Also the lobby ends after about 15 seconds of existing, so the lobby kills itself. create lobby you get tpd to the lobby 10 seconds or so, lobby ends but you stay in where it tpd you. no message or anything. it just stops.

sennby commented 6 days ago

-[20:36:58 INFO]: _Senby issued server command: /dg join BeeHiveDungeon [20:36:58 INFO]: [Essentials] CONSOLE issued server command: /broadcast DUNGEON STARTING!! Enter the BeeHive Dungeon for a thrilling adventure filled with buzzing bosses and swarming monsters! WHERE? [/dungeon join BeeHiveDungeon] [20:36:59 INFO]: [CoreArena] GG! The game in BeeHiveDungeon has finished!

sennby commented 4 days ago

@kangarko ?

where do i go from here??

kangarko commented 2 days ago

Sorry, I will addressing this in 24 hours

kangarko commented 1 day ago

I can't reproduce the lobby bug, works fine for me on Paper 1.21.1:

a

Please test on the new update I will push out tonight.

In regards for the phase bug, I figured out it was a confusing setting, I apology for that. Please set Phase.Max_Phase to -1 and keep Arena_End as-is in your arena .yml file, because having both will break the logic.

sennby commented 1 day ago

[15:22:38 INFO]: WhoIsSenby issued server command: /dg join BeeHiveDungeon

[15:22:38 INFO]: [Essentials] CONSOLE issued server command: /broadcast DUNGEON STARTING!! Enter the BeeHive Dungeon for a thrilling adventure filled with buzzing bosses and swarming monsters! WHERE? [/dungeon join BeeHiveDungeon] [15:22:43 INFO]: [CoreArena] GG! The game in BeeHiveDungeon has finished!

sennby commented 1 day ago

When i go to this arena and do /dg edit. Could not find an arena by your location. Despite me just redoing the points.

So i went flying around and foudn i had emerald blocks named as unknown something. so i went and removed teh arena points (there was 3???) redid the points and the issue fixed. So the arena points bugged for some reason on conversion. I am good now.

kangarko commented 1 day ago

Ooh super strange. So it's all good now? If it should happen more, you can - if possible - just send me the server with the map (in private works too) and if I have time I can try reproducing 1:1.

You can also see the data.db file open it with a text editor and see if anything suspicious is stored there.

sennby commented 1 day ago

Okay so i started thedungeon. it went STRAIGHT to round 5 (the final round, eg the boss round).

All mobs ppretty much were dead on 1-4 and 5 stayed the rest didnt. (bees) But the same mobs were spawned in 5 and stayed alive.

sennby commented 1 day ago

You can add me on discord: senby8

kangarko commented 1 day ago

I am leaving office for the weekend, please send me the environment in private via email at matej@mineacademy.org