search

kangarko / Foundation

Foundation™ helps you create highly customized Minecraft plugins (based on Spigot/Paper API) that support multiple MC versions.
https://mineacademy.org
316 stars 64 forks source link

Add support for multiple decorations in ChatUtil#generateGradient #229

Closed Ultimating closed 1 year ago

Ultimating commented 1 year ago

This is a feature implemented in my premium plugin, UltraColorPro. I figured Foundation could benefit from this feature. I have tested it on my end and everything works.

-Ultimation

kangarko commented 1 year ago

Thank you and I would love to pull, but you are not following our contributor guidelines - the entire class is marked red and replaced. Reformat using the original formatting so the commit only renders the actual changes

broken1arrow commented 1 year ago

Thank you and I would love to pull, but you are not following our contributor guidelines - the entire class is marked red and replaced. Reformat using the original formatting so the commit only renders the actual changes

This is a pain, that is why I turn of the save action. It always breaks the original formatting you need to be careful when you use ctrl + alt + l also and only mark the parts you want to format.

Ultimating commented 1 year ago

I thought I wasn't using save actions and disabled it before I committed and made this request. But there were some settings I didn't catch.

@kangarko The original reformatting should be restored in the 2 commits I pushed. Though, this is also the first pull request I've ever made, so not sure if I did what you asked correctly.

kangarko commented 1 year ago

Unfortunately the Files Changed still shows the whole thing changed, please open a new pull request with the fixed formatting instead