search

kangarko / Foundation

Foundation™ helps you create highly customized Minecraft plugins (based on Spigot/Paper API) that support multiple MC versions.
https://mineacademy.org
305 stars 63 forks source link

1.20.4: Custom enchantment name not showing on all compatible items #302

Closed Scraft161 closed 1 month ago

Scraft161 commented 1 month ago

Hi, I am running minecraft paper 1.20.4 with a custom plugin made with Foundation following the custom enchants tutorial, after getting it to work and trying it on a couple of items I noticed it doesn't show the lore on all items.

I am using the minecraft:enchant command which seems to work properly: command feedback: Applied enchantment enchantment.minecraft.soulbound III to Scraft161's item

it then only displays on certain items: Enchanted Netherite Axe with no enchants listed Enchanted Wooden shovel with Soulbound III listed Enchanted Netherite Sword with no enchantments listed Enchanted Wooden Sword with Soulbound III listed

some other items that I've noticed that don't list it are: enchanted_book, netherite_chestplate, and turtle_shell, this is by no means an exhaustive list, although I could check all the enchantable items if needed.

I am using Foundation 6.7.15 and ProtocolLib 5.2.0, I am however quite new to minecraft plugin development so it might be that I bunged something up, source code is available at Scraft161/Simple-Soulbound if you want a read through, the main plugin class is /src/main/java/dev/scraft/SimpleSoulbound/Plugin.java.

kangarko commented 1 month ago

Probably a MC or protocollib bug, unfortunately I dont have the the time constrains to debug this. Contributions are welcome.