search

kangax / html-minifier

Javascript-based HTML compressor/minifier (with Node.js support)
http://kangax.github.io/html-minifier/
MIT License
4.92k stars 568 forks source link

Add CodeQL workflow #1106

Closed XhmikosR closed 2 years ago

XhmikosR commented 2 years ago

@kangax can you give me admin rights or remove Travis CI? I will switch to GitHub Actions later.

XhmikosR commented 2 years ago

@kangax friendly ping ^^

kangax commented 2 years ago

How do we remove it? I checked and it looks like you have "collaborator" access on the repo and there's no other option to select.

XhmikosR commented 2 years ago

I planned to also switch branches around and use an Action to deploy. I don't have any other ideas, might be a limitation due to the fact that this repo is a personal one.

So, repo Settings -> Webhooks/Integrations make sure you remove any Travis CI references. Then go to the branch protection rules and adapt it so it's using the Actions from #1107.

kangax commented 2 years ago

@XhmikosR ok I think this should do it

XhmikosR commented 2 years ago

Are you sure you added the new Actions in the branch protection rules? Because I see I can merge this PR, but no CI has run.

Can you review/approve #1107 and then go to the repo settings to protect the branch again?

XhmikosR commented 2 years ago

BTW another handy option is the option to delete HEAD branches :)

XhmikosR commented 2 years ago

@kangax can you enable the aforementioned option + the option for the branch to be up to date?

Trying to see how we are going to make the switch from gh-pages to main, and not having the needed rights makes this more complex.

kangax commented 2 years ago

@XhmikosR enabled "automatically delete head branches". I don't quite understand if there's anything else I can do in "Require status checks to pass before merging" section. I tried searching in their input field and seeing things like Node 10, Analyze, Page Build, etc. Those are not the same ones as what you added afaics, and when I search for yours nothing comes up.

XhmikosR commented 2 years ago

@kangax yeah, that's normal. So, just choose 10, 12, 14, 16. CodeQL might be good too.

XhmikosR commented 2 years ago

So, the question is how we solve the 2-3 issues that are valid and are in our source code: https://github.com/kangax/html-minifier/security/code-scanning