Add CodeMirror to highlight code

kangax / jscritic

Quickly check how well 3rd party script behaves.

jscritic.com

118 stars 8 forks source link

Add CodeMirror to highlight code #9

Open XhmikosR opened 10 years ago

mathiasbynens commented 10 years ago

For funsies, I ran Codemirror through JSCritic. Its only flaws are:

it does User-Agent sniffing
it has 8 unused variables: next, updated, updateInput, range, mX, mY, style, ok

XhmikosR commented 10 years ago

Do you know of any good alternative? I only suggested CodeMirror because I have seen it being used a lot, but anything should do the job.

kangax commented 10 years ago

It's a good suggestion.

I'm only worried about slowdown when pasting large chunks of code. JSCritic is already slow (could use web workers big time) when doing analysis, so it could get it even worse...

XhmikosR commented 10 years ago

I don't think highlighting will slow down things a lot. But I don't have any numbers. We can try it and see how it goes maybe?

kangax commented 10 years ago

Sure.

Sent from my iPhone

On Apr 2, 2014, at 0:38, XhmikosR notifications@github.com wrote:

I don't think highlighting will slow down things a lot. But I don't have any numbers. We can try it and see how it goes maybe?

— Reply to this email directly or view it on GitHub.