search

kangguru / botvac

Other
44 stars 11 forks source link

Use oauth? #3

Open ostinelli opened 7 years ago

ostinelli commented 7 years ago

Hello @kangguru! Let me introduce myself, I am Roberto Ostinelli, Neato Robotics' Director of Cloud Services.

I'm impressed with the work that you've put into integrating with our robots! Great job!

Given the interest that we've seen from developers like yourself and around the forums we've listened and have just released the Neato Developer Network. In there, amongst other things you will find official documentation and SDKs for JavaScript, iOS and Android (for now, we plan on expanding to other languages too!).

This issue is for you to consider switching to proper OAuth instead of the internal logins mechanisms that you are using in this gem.

It would be the official way to proceed, and you would avoid some improper implementations. For example, you should not pass token and platform here: they are not needed, raise errors on our systems - since tokens are invalid - and this could eventually result in the blocking of user accounts by our automated systems if abused. We definitely wouldn't want that!

Please note that all of this is in Beta, we're a small team but are doing our best!

All the best, r.

kangguru commented 7 years ago

hej @ostinelli i'm really happy to hear that you're opening up your robot API to other developers! thats great news :)

With this new possibility i'll port my library to support the official way. Thank you for reaching out, i'll keep you posted on the process.

qelanhari commented 7 years ago

I don't have the time to look deep into this right now; but yep this is great great news !

ostinelli commented 7 years ago

That's great! Let me know if we can help!