Closed jarl-dk closed 10 years ago
I must admit I am a bit new to Google Analytics...
Is this Pull Request pointless? Is the google analytics behaviour provided with this:
config.middleware.use Rack::GoogleAnalytics,{
:tracker => 'UA-12345-1',
:async => true,
:multiple => true,
}
exactly the same as this:
config.middleware.use Rack::GoogleAnalytics,{
:tracker => 'UA-12345-1',
:async => true,
}
I ask, because if so, the pull request seem pointless
As the default behavior of setDomainName
is auto
which will try to obtain the current host from _setDomainName
this will be pretty much the same. Only thing is that you'll have to also set the domain
config if you use the multiple
option.
So your point is when not having multiple domains, the default behaviour is automatic domain detection and setting. Setting the domain option is only necessary when :multiple => true
.
If so, maybe some description of this in the README would help.
Setting domain automatically based on Rack request environment.