search

kangguru / rack-google-analytics

Simple Rack middleware for implementing google analytics tracking in your Ruby-Rack based project. Supports synchronous and asynchronous insertion and configurable load options
MIT License
257 stars 53 forks source link

Add activesupport dependency #34

Closed arthurnn closed 10 years ago

arthurnn commented 10 years ago

https://github.com/kangguru/rack-google-analytics/blob/master/lib/rack-google-analytics.rb#L1 requires activesupport so we need to add it as a dependency.

Figured that, when trying to add it to octostalker https://github.com/arthurnn/octostalker/commit/9d8452adcf841e4fd87baf20e96368af9259680e . See that I had to add activesupport otherwise it wouldnt work.

kangguru commented 10 years ago

oh yes. you're totally right.

but while looking at this. i'm wondering if

 s.add_development_dependency 'actionpack'

makes sense ;)

arthurnn commented 10 years ago

:heart:

arthurnn commented 10 years ago

I saw you end-up adding actionpack as a dependency, wondering why we need actionpack as a dependency.