kangqiao322 / pe

0 stars 0 forks source link

Allowing duplication of tutors of the same name and phone number but different emails for add person command #7

Open kangqiao322 opened 1 year ago

kangqiao322 commented 1 year ago

Tutors with the same name and phone numbers should be the same person but it is possible they have multiple emails and should not be counted as different people.

image.png

image.png

Steps to reproduce:

Step 1: type "add tutor n/Betsy Crowe p/1234567 e/betsycrowe@example.com a/Newgate st, block 123, #01-01 q/MSc, Master of Science i/National University of Singapore

/mostLiked"

Step 2: type "add tutor n/Betsy Crowe p/1234567 e/betowe@example.com a/Newgate st, block 123, #01-01 q/MSc, Master of Science i/National University of Singapore

/mostLiked"

soc-se-bot commented 1 year ago

Team's Response

We only see duplicate entries as having all the same particulars. This is to allow for flexibility incase there are people with the same name and same phone number, etc. This was our design choice.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Multiple people with the same name and phone number should be counted as duplicates as phone numbers are unique to each person. If a person has for example has 5 emails and he/she inputs all of them into the application , it will lead to a duplication of data of the same person and clutter the app with repetitive information. It is illogical for a person with the same name and phone to be considered separate people just because they have different emails, especially if they are adult tutors who do not share such things.