search

kangqiao322 / pe

0 stars 0 forks source link

Incorrect warning when wrong date is input for adding classes #8

Open kangqiao322 opened 1 year ago

kangqiao322 commented 1 year ago

As can be seen here, 119pm is an invalid date and time but the warning given for it is instead that the class already exists in the application:

image.png

Steps to reproduce:

Step 1: Type "add class n/S1ENGT10 s/Math l/Secondary 1 d/Thursday t/10am to 12pm"

Step 2 : Type "add class n/S1ENGT10 s/Math l/Secondary 1 d/Friday t/10am to 119pm"

It might be better for the warning of the date to come first.

soc-se-bot commented 1 year ago

Team's Response

Only the first error would be shown which in this case is the duplicate class name.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]