kanidm / ldap3

Rust LDAP3 Server Protocol Library
Mozilla Public License 2.0
51 stars 11 forks source link

Move Ldap Controls to another file #42

Closed irvingoujAtDevolution closed 9 months ago

irvingoujAtDevolution commented 9 months ago

organize the Ldap Control code to another file, makes it easier to add more control sequence in the future

Firstyear commented 9 months ago

Just moving code around, quite uncontroversial

If there are other library structure changes you want to see, please lmk. I'm very open to them, as this library has "evolved" more than "was planned" so it shows that in it's structure.

Note: avoid commit messages such as "commit"

I would have reworded it on squash in this case, but yeah, better to just word it right from the start.

irvingoujAtDevolution commented 9 months ago

updated commit message. as explained in there, this change is necessary. @CBenoit

We plan on adding more control options, as Ldap Control by it's nature is very extensible and vendor dependent, it would be hard to add more controls if it stay in the proto.rs file

Edit

I misread the comments, nevermind. 👍

Firstyear commented 9 months ago

@irvingoujAtDevolution No problem at all, you're doing great work here!