search

kanidm / webauthn-rs

An implementation of webauthn components for Rustlang servers
Mozilla Public License 2.0
485 stars 80 forks source link

Support hybrid in AuthenticatorTransport #219

Closed moubctez closed 1 year ago

moubctez commented 1 year ago

I did this

A front-end application I've got is using @github/webauthn-json/browser-ponyfill and that sends hybrid as a value for transport. In particular, that is happening when I use Touch ID.

I see Hybrid is commented-out in pub enum AuthenticatorTransport. Would it be possible to add/uncomment it?

Here is a related issue for @github/webauthn-json/browser-ponyfill:

https://github.com/github/webauthn-json/issues/67

I expected the following

Hybrid transport is supported.

What actually happened

There is an error:

Error("unknown variant `hybrid`, expected one of `usb`, `nfc`, `ble`, `internal`", line: 1, column: 658)).

Version (and git commit)

webauthn-rs v0.4.7

Firstyear commented 1 year ago

Thanks, I have put in a PR for this. It was left commented because it's part of the draft level 3 specification and isn't "standardised" yet (it's already been renamed from caBLE to hybrid).

What device were you using that had hybrid as a transport?

moubctez commented 1 year ago

That's on Safari 16.1 on macOS 12.6.

Firstyear commented 1 year ago

@moubctez It will be resolved in 0.4.8 that I am releasing today. :) let us know if there is anything else!